Disallow CREATE STATISTICS on system catalogs
authorTomas Vondra <tomas.vondra@postgresql.org>
Fri, 15 Jan 2021 22:24:19 +0000 (23:24 +0100)
committerTomas Vondra <tomas.vondra@postgresql.org>
Fri, 15 Jan 2021 22:32:54 +0000 (23:32 +0100)
commitd26d4c717dbfb24cc9dfd83044b5c9a377dc954a
tree6344e028b0c9395a595522dd26c5d5a441531dc1
parentf44ae4db5feccb8012c1b2df169bf87576ce760e
Disallow CREATE STATISTICS on system catalogs

Add a check that CREATE STATISTICS does not add extended statistics on
system catalogs, similarly to indexes etc.  It can be overriden using
the allow_system_table_mods GUC.

This bug exists since 7b504eb282c, adding the extended statistics, so
backpatch all the way back to PostgreSQL 10.

Author: Tomas Vondra
Reported-by: Dean Rasheed
Backpatch-through: 10
Discussion: https://postgr.es/m/CAEZATCXAPrrOKwEsyZKQ4uzzJQWBCt6QAvOcgqRGdWwT1zb%2BrQ%40mail.gmail.com
src/backend/commands/statscmds.c
src/test/regress/expected/stats_ext.out
src/test/regress/sql/stats_ext.sql