Fix dumping role comments when using --no-role-passwords
authorDaniel Gustafsson <dgustafsson@postgresql.org>
Thu, 21 Mar 2024 22:31:57 +0000 (23:31 +0100)
committerDaniel Gustafsson <dgustafsson@postgresql.org>
Thu, 21 Mar 2024 22:31:57 +0000 (23:31 +0100)
commitaffc46b76d50a42c44ae1322545769eceaa509c6
tree1708f7c4605373451fa38effb851ecd2e6a1e068
parent520e7afa5732b0ba27b55f99dbabeea5e2591bb7
Fix dumping role comments when using --no-role-passwords

Commit 9a83d56b38c added support for allowing pg_dumpall to dump
roles without including passwords, which accidentally made dumps
omit COMMENTs on roles.  This fixes it by using pg_authid to get
the comment.

Backpatch to all supported versions. Patch simultaneously written
independently by Álvaro and myself.

Author: Álvaro Herrera <alvherre@alvh.no-ip.org>
Author: Daniel Gustafsson <daniel@yesql.se>
Reported-by: Bartosz Chroł <bartosz.chrol@handen.pl>
Discussion: https://postgr.es/m/AS8P194MB1271CDA0ADCA7B75FCD8E767F7332@AS8P194MB1271.EURP194.PROD.OUTLOOK.COM
Discussion: https://postgr.es/m/CAEP4nAz9V4H41_4ESJd1Gf0v%3DdevkqO1%3Dpo91jUw-GJSx8Hxqg%40mail.gmail.com
Backpatch-through: v12
src/bin/pg_dump/pg_dumpall.c