Clean up the use of some page-header-access macros: principally, use
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 13 Jul 2008 20:45:47 +0000 (20:45 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 13 Jul 2008 20:45:47 +0000 (20:45 +0000)
commit8ec0437466bc4bcbfd7f211765e4a7587ff3f4d6
treedfed31431c8739b9ef3be070737f621544044b5d
parent5750ec0ee69f1376016ae822904be450372ac848
Clean up the use of some page-header-access macros: principally, use
SizeOfPageHeaderData instead of sizeof(PageHeaderData) in places where that
makes the code clearer, and avoid casting between Page and PageHeader where
possible.  Zdenek Kotala, with some additional cleanup by Heikki Linnakangas.

I did not apply the parts of the proposed patch that would have resulted in
slightly changing the on-disk format of hash indexes; it seems to me that's
not a win as long as there's any chance of having in-place upgrade for 8.4.
17 files changed:
src/backend/access/gist/gistutil.c
src/backend/access/hash/hashutil.c
src/backend/access/heap/heapam.c
src/backend/access/heap/hio.c
src/backend/access/heap/pruneheap.c
src/backend/access/nbtree/nbtpage.c
src/backend/access/transam/xlog.c
src/backend/access/transam/xlogutils.c
src/backend/commands/sequence.c
src/backend/commands/trigger.c
src/backend/optimizer/util/plancat.c
src/backend/storage/buffer/bufmgr.c
src/include/access/hash.h
src/include/access/htup.h
src/include/access/itup.h
src/include/access/nbtree.h
src/include/access/tuptoaster.h