Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 10 Feb 2025 21:30:03 +0000 (16:30 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 10 Feb 2025 21:30:31 +0000 (16:30 -0500)
commit85c1fcc6563843d7ee7ae6f81f29ef813e77a4b6
tree1f849bf770f846f87070b9252bbd9b6d4252c50c
parent05abb0f8303a78921f7113bee1d72586142df99e
Adapt appendPsqlMetaConnect() to the new fmtId() encoding expectations.

We need to tell fmtId() what encoding to assume, but this function
doesn't know that.  Fortunately we can fix that without changing the
function's API, because we can just use SQL_ASCII.  That's because
database names in connection requests are effectively binary not text:
no encoding-aware processing will happen on them.

This fixes XversionUpgrade failures seen in the buildfarm.  The
alternative of having pg_upgrade use setFmtEncoding() is unappetizing,
given that it's connecting to multiple databases that may have
different encodings.

Andres Freund, Noah Misch, Tom Lane

Security: CVE-2025-1094
src/fe_utils/string_utils.c