projects / users / rhaas / postgres.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 97ff8dd) | patch
Code review for commit b6e1157e7d
authorAmit Langote <amitlan@postgresql.org>
Fri, 21 Jul 2023 10:15:34 +0000 (19:15 +0900)
committerAmit Langote <amitlan@postgresql.org>
Fri, 21 Jul 2023 10:15:34 +0000 (19:15 +0900)
commit7c7412cae3ea8f8accdec1022969a9360b74f253
tree1ce80497cc5adbe9a33723740a296de929000664tree
parent97ff8dd02ca788020021cdafb85d77d4fd3f3125commit | diff
Code review for commit b6e1157e7d

b6e1157e7d made some changes to enforce that
JsonValueExpr.formatted_expr is always set and is the expression that
gives a JsonValueExpr its runtime value, but that's not really
apparent from the comments about and the code manipulating
formatted_expr.  This commit fixes that.

Per suggestion from Álvaro Herrera.

Discussion: https://postgr.es/m/20230718155313.3wqg6encgt32adqb%40alvherre.pgsql
src/backend/nodes/makefuncs.c diff | blob | blame | history
src/backend/nodes/nodeFuncs.c diff | blob | blame | history
src/backend/parser/gram.y diff | blob | blame | history
src/backend/parser/parse_expr.c diff | blob | blame | history
src/include/nodes/makefuncs.h diff | blob | blame | history
src/include/nodes/primnodes.h diff | blob | blame | history
Robert Haas's development tree.