Remove dead setenv, unsetenv replacement code.
authorThomas Munro <tmunro@postgresql.org>
Thu, 4 Aug 2022 21:38:36 +0000 (09:38 +1200)
committerThomas Munro <tmunro@postgresql.org>
Thu, 4 Aug 2022 21:38:36 +0000 (09:38 +1200)
commit71f5dc6dfb3de50de28ddde53793540c2fa98b1f
treebda25fad6c14f222f5f0e6416fe92bb3b3fc03af
parentb79ec732d29fe42e91aeab4da62d446f226b594a
Remove dead setenv, unsetenv replacement code.

setenv() and unsetenv() are in SUSv3 and targeted Unix systems have
them.  We still need special code for these on Windows, but that doesn't
require a configure probe.

This marks the first time we require a SUSv3 (POSIX.1-2001) facility
(rather than SUSv2).  The replacement code removed here was not needed
on any targeted system or any known non-EOL'd Unix system, and was
therefore dead and untested.

No need for vestigial HAVE_SETENV and HAVE_UNSETENV macros, because we
provide a replacement for Windows, and we didn't previously test the
macros.

Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Reviewed-by: Greg Stark <stark@mit.edu>
Reviewed-by: Robert Haas <robertmhaas@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CA+hUKGJ3LHeP9w5Fgzdr4G8AnEtJ=z=p6hGDEm4qYGEUX5B6fQ@mail.gmail.com
configure
configure.ac
src/include/pg_config.h.in
src/include/port.h
src/port/setenv.c [deleted file]
src/port/unsetenv.c [deleted file]
src/tools/msvc/Solution.pm