Fix TestLib::slurp_file() with offset on windows.
authorAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:28:06 +0000 (13:28 -0700)
committerAndres Freund <andres@anarazel.de>
Mon, 4 Oct 2021 20:32:35 +0000 (13:32 -0700)
commit5ba397f7404e911c7822e85441d42673080c5b98
tree442d074ceddac7c11ce3405b4bb845e50ed1a7e7
parentc53ff69e1fd24ae4905fe50ce8d3ca3a08d6a3c2
Fix TestLib::slurp_file() with offset on windows.

3c5b0685b921 used setFilePointer() to set the position of the filehandle, but
passed the wrong filehandle, always leaving the position at 0. Instead of just
fixing that, remove use of setFilePointer(), we have a perl fd at this point,
so we can just use perl's seek().

Additionally, the perl filehandle wasn't closed, just the windows filehandle.

Reviewed-By: Andrew Dunstan <andrew@dunslane.net>
Author: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/20211003173038.64mmhgxctfqn7wl6@alap3.anarazel.de
Backpatch: 9.6-, like 3c5b0685b921
src/test/perl/TestLib.pm