From 58446a66f8d7f461de0407f41a15e8fd9fe9035c Mon Sep 17 00:00:00 2001 From: Taiki Koshino Date: Wed, 10 Sep 2025 15:28:01 +0900 Subject: [PATCH] Fix safer directory deletion in Bash in recovery_1st_stage.sample. Quote variables in rm commands to avoid accidental deletion: rm -rf "${DEST_NODE_PGDATA}" If the variable is empty, rm could delete unexpected files or directories. --- src/sample/scripts/recovery_1st_stage.sample | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/sample/scripts/recovery_1st_stage.sample b/src/sample/scripts/recovery_1st_stage.sample index f62500f47..9cbe33c8a 100755 --- a/src/sample/scripts/recovery_1st_stage.sample +++ b/src/sample/scripts/recovery_1st_stage.sample @@ -49,7 +49,7 @@ ssh -T ${SSH_OPTIONS} ${POSTGRESQL_STARTUP_USER}@$DEST_NODE_HOST " set -o errexit - [ -d \"${DEST_NODE_PGDATA}\" ] && rm -rf ${DEST_NODE_PGDATA} + [ -d \"${DEST_NODE_PGDATA}\" ] && rm -rf \"${DEST_NODE_PGDATA}\" ${PGHOME}/bin/pg_basebackup -h $PRIMARY_NODE_HOST -U $REPLUSER -p $PRIMARY_NODE_PORT -D $DEST_NODE_PGDATA -X stream -- 2.39.5