From 27da92efb0be66dfc1a68a6da469808c5f6f1df2 Mon Sep 17 00:00:00 2001 From: Magnus Hagander Date: Mon, 19 Jan 2015 22:22:56 +0100 Subject: [PATCH] Fix sorting of users (committers, authors and reviewers) --- pgcommitfest/commitfest/forms.py | 2 +- pgcommitfest/commitfest/models.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/pgcommitfest/commitfest/forms.py b/pgcommitfest/commitfest/forms.py index 930f5ef..2a832ae 100644 --- a/pgcommitfest/commitfest/forms.py +++ b/pgcommitfest/commitfest/forms.py @@ -27,7 +27,7 @@ class CommitFestFilterForm(forms.Form): self.fields['status'] = forms.ChoiceField(choices=c, required=False) q = Q(patch_author__commitfests=cf) | Q(patch_reviewer__commitfests=cf) - userchoices = [(-1, '* All'), (-2, '* None'), (-3, '* Yourself') ] + [(u.id, '%s %s (%s)' % (u.first_name, u.last_name, u.username)) for u in User.objects.filter(q).distinct()] + userchoices = [(-1, '* All'), (-2, '* None'), (-3, '* Yourself') ] + [(u.id, '%s %s (%s)' % (u.first_name, u.last_name, u.username)) for u in User.objects.filter(q).distinct().order_by('last_name', 'first_name')] self.fields['author'] = forms.ChoiceField(choices=userchoices, required=False) self.fields['reviewer'] = forms.ChoiceField(choices=userchoices, required=False) diff --git a/pgcommitfest/commitfest/models.py b/pgcommitfest/commitfest/models.py index 21fe733..d60a1aa 100644 --- a/pgcommitfest/commitfest/models.py +++ b/pgcommitfest/commitfest/models.py @@ -19,6 +19,9 @@ class Committer(models.Model): def fullname(self): return "%s %s (%s)" % (self.user.first_name, self.user.last_name, self.user.username) + class Meta: + ordering = ('user__last_name', 'user__first_name') + class CommitFest(models.Model): STATUS_FUTURE=1 STATUS_OPEN=2 -- 2.39.5