Tom Lane [Sat, 23 Apr 2005 05:38:43 +0000 (05:38 +0000)]
int_aggregate's int_enum() doesn't work correctly with arrays that
aren't 1-D, so give an error message instead of failing. Per report
from Ron Mayer.
Bruce Momjian [Fri, 22 Apr 2005 15:53:27 +0000 (15:53 +0000)]
Backpatch of LIMIT / FOR UPDATE behavior, but keep pre-7.3 mention in 8.0.X.
Bruce Momjian [Fri, 22 Apr 2005 04:19:02 +0000 (04:19 +0000)]
Clarify that only crypt can't use md5 pg_shadow passwords.
Bruce Momjian [Thu, 21 Apr 2005 22:19:27 +0000 (22:19 +0000)]
Clarify use of MD5 authentication and pg_shadow encryption.
Tom Lane [Wed, 20 Apr 2005 23:10:22 +0000 (23:10 +0000)]
Make pg_ctl status do a kill() test to verify that the PID found in
postmaster.pid still represents a live postmaster.
Tom Lane [Wed, 20 Apr 2005 21:48:12 +0000 (21:48 +0000)]
Don't try to run clauseless index scans on index types that don't support
it. Per report from Marinos Yannikos.
Tom Lane [Wed, 20 Apr 2005 17:14:58 +0000 (17:14 +0000)]
Fix mis-display of negative fractional seconds in interval values for
--enable-integer-datetimes case. Per report from Oliver Siegmar.
Teodor Sigaev [Tue, 19 Apr 2005 13:58:11 +0000 (13:58 +0000)]
Add comment about permissions on pg_ts* tables
Bruce Momjian [Tue, 19 Apr 2005 01:40:02 +0000 (01:40 +0000)]
Update PITR wording, per Simon.
Tom Lane [Mon, 18 Apr 2005 23:48:01 +0000 (23:48 +0000)]
pg_dumpall should enforce the server version check for itself, rather
than simply passing it down to pg_dump. Else, version-related failures
in pg_dumpall itself generate unhelpful error messages.
Tom Lane [Mon, 18 Apr 2005 17:11:15 +0000 (17:11 +0000)]
record_in and record_recv must be careful to return a separately
pfree'able result, since some callers expect to be able to pfree
the result of a pass-by-reference function. Per report from Chris Trawick.
Bruce Momjian [Mon, 18 Apr 2005 01:29:08 +0000 (01:29 +0000)]
Update PITR mention of which WAL files are needed.
Bruce Momjian [Sun, 17 Apr 2005 03:05:27 +0000 (03:05 +0000)]
Clarify name of file to be checked for PITR expiring.
Bruce Momjian [Fri, 15 Apr 2005 22:49:45 +0000 (22:49 +0000)]
Fix comment typo.
Tom Lane [Fri, 15 Apr 2005 16:40:59 +0000 (16:40 +0000)]
Revert addition of poorly-thought-out DUMP TIMESTAMP archive entry,
which induced bug #1597 in addition to having several other misbehaviors
(like labeling the dump with a completion time having nothing to do with
reality). Instead just print out the desired strings where RestoreArchive
was already emitting the 'PostgreSQL database dump' and
'PostgreSQL database dump complete' strings.
Tom Lane [Thu, 14 Apr 2005 22:35:12 +0000 (22:35 +0000)]
Make equalTupleDescs() compare attlen/attbyval/attalign rather than
assuming comparison of atttypid is sufficient. In a dropped column
atttypid will be 0, and we'd better check the physical-storage data
to make sure the tupdescs are physically compatible.
I do not believe there is a real risk before 8.0, since before that
we only used this routine to compare successive states of the tupdesc
for a particular relation. But 8.0's typcache.c might be comparing
arbitrary tupdescs so we'd better play it safer.
Tom Lane [Thu, 14 Apr 2005 21:44:22 +0000 (21:44 +0000)]
Don't try to constant-fold functions returning RECORD, since the optimizer
isn't presently set up to pass them an expected tuple descriptor. Bug has
been there since 7.3 but was just recently reported by Thomas Hallgren.
Michael Meskes [Thu, 14 Apr 2005 10:09:20 +0000 (10:09 +0000)]
Added patch by Philip Yarra <philip.yarra@internode.on.net> for a bug in thread support.
Tom Lane [Mon, 11 Apr 2005 19:51:32 +0000 (19:51 +0000)]
Fix interaction between materializing holdable cursors and firing
deferred triggers: either one can create more work for the other,
so we have to loop till it's all gone. Per example from andrew@supernews.
Add a regression test to help spot trouble in this area in future.
Tom Lane [Mon, 11 Apr 2005 15:59:47 +0000 (15:59 +0000)]
PersistHoldablePortal must establish the correct value for ActiveSnapshot
while completing execution of the cursor's query. Otherwise we get wrong
answers or even crashes from non-volatile functions called by the query.
Per report from andrew@supernews.
Tom Lane [Sun, 10 Apr 2005 20:57:45 +0000 (20:57 +0000)]
Make constant-folding produce sane output for COALESCE(NULL,NULL),
that is a plain NULL and not a COALESCE with no inputs. Fixes crash
reported by Michael Williamson.
Tom Lane [Sun, 10 Apr 2005 18:04:31 +0000 (18:04 +0000)]
SQL functions returning pass-by-reference types were copying the results
into the wrong memory context, resulting in a query-lifespan memory leak.
Bug is new in 8.0, I believe. Per report from Rae Stiening.
Tom Lane [Thu, 7 Apr 2005 19:43:06 +0000 (19:43 +0000)]
Stamp 8.0.2.
Tom Lane [Thu, 7 Apr 2005 19:04:19 +0000 (19:04 +0000)]
Update and copy-edit release notes for 8.0.2.
Tom Lane [Mon, 4 Apr 2005 01:43:23 +0000 (01:43 +0000)]
In cost_mergejoin, the early-exit effect should not apply to the
outer side of an outer join. Per andrew@supernews.
Tom Lane [Sun, 3 Apr 2005 00:02:03 +0000 (00:02 +0000)]
Put back code mistakenly removed from copy of postmaster's
daemonize routine, namely forcing stdin/stdout/stderr to point
to /dev/null. Per Karl Denninger.
Peter Eisentraut [Sat, 2 Apr 2005 18:45:19 +0000 (18:45 +0000)]
Translation updates
Peter Eisentraut [Sat, 2 Apr 2005 15:54:57 +0000 (15:54 +0000)]
Translation updates
Bruce Momjian [Sat, 2 Apr 2005 03:43:08 +0000 (03:43 +0000)]
Fix release not typo.
Bruce Momjian [Sat, 2 Apr 2005 02:42:59 +0000 (02:42 +0000)]
Update release notes for 8.0.2.
Tom Lane [Fri, 1 Apr 2005 20:32:09 +0000 (20:32 +0000)]
Second try at making examine_variable and friends behave sanely in
cases with binary-compatible relabeling. My first try was implicitly
assuming that all operators scalarineqsel is used for have binary-
compatible datatypes on both sides ... which is very wrong of course.
Per report from Michael Fuhr.
Bruce Momjian [Fri, 1 Apr 2005 16:42:59 +0000 (16:42 +0000)]
Backpatch FAQ's to 8.0.X.
Bruce Momjian [Fri, 1 Apr 2005 14:25:39 +0000 (14:25 +0000)]
Fix wrong week returnded by date_trunc('week') for early dates in
January --- would return wrong year for 2005-01-01 and 2006-01-01.
per report from Robert Creager.
Backpatch to 8.0.X.
Tom Lane [Thu, 31 Mar 2005 23:21:09 +0000 (23:21 +0000)]
Flush any remaining statistics counts out to the collector at process
exit. Without this, operations triggered during backend exit (such as
temp table deletions) won't be counted ... which given heavy usage of
temp tables can lead to pg_autovacuum falling way behind on the need
to vacuum pg_class and pg_attribute. Per reports from Steve Crawford
and others.
Peter Eisentraut [Thu, 31 Mar 2005 18:14:25 +0000 (18:14 +0000)]
Translation updates
Teodor Sigaev [Thu, 31 Mar 2005 15:10:48 +0000 (15:10 +0000)]
Fix various comparing functions
Neil Conway [Wed, 30 Mar 2005 05:06:32 +0000 (05:06 +0000)]
Document that the "-P" option to pg_autovacuum is insecure on many
platforms, and suggest using ~/.pgpass instead.
Tom Lane [Sat, 26 Mar 2005 20:55:58 +0000 (20:55 +0000)]
Fix a pair of related issues with estimation of inequalities that involve
binary-compatible relabeling of one or both operands. examine_variable
should avoid stripping RelabelType from non-variable expressions, so that
they will continue to have the correct type; and convert_to_scalar should
just use that type and ignore the other input type. This isn't perfect
but it beats failing entirely. Per example from Michael Fuhr.
Bruce Momjian [Sat, 26 Mar 2005 05:05:23 +0000 (05:05 +0000)]
Make additional stamps for 8.0.2.
PostgreSQL Daemon [Sat, 26 Mar 2005 03:46:33 +0000 (03:46 +0000)]
Tag for 8.0.2beta1
Tom Lane [Sat, 26 Mar 2005 03:38:11 +0000 (03:38 +0000)]
Add Windows-specific variant comparison file.
Tom Lane [Sat, 26 Mar 2005 02:14:54 +0000 (02:14 +0000)]
Add another ORDER BY to rules test to eliminate platform-specific
output ordering.
Tom Lane [Sat, 26 Mar 2005 00:41:45 +0000 (00:41 +0000)]
Prevent to_char(interval) from dumping core on month-related formats
when a zero-month interval is given. Per discussion with Karel.
Also, some desultory const-labeling of constant tables. More could be
done along that line.
Tom Lane [Fri, 25 Mar 2005 22:51:42 +0000 (22:51 +0000)]
Remove lazy_update_relstats; go back to having VACUUM just record the
actual number of unremoved tuples as pg_class.reltuples. The idea of
trying to estimate a steady state condition still seems attractive, but
this particular implementation crashed and burned ...
Bruce Momjian [Fri, 25 Mar 2005 18:18:41 +0000 (18:18 +0000)]
Have libpgport link before libpq so that PG client applications are more
immunte to changes in libpq's usage of pgport between major versions.
Backpatch to 8.0.X.
Tom Lane [Fri, 25 Mar 2005 18:04:47 +0000 (18:04 +0000)]
Fix two bugs in change_owner_recurse_to_sequences: it was grabbing an
overly strong lock on pg_depend, and it wasn't closing the rel when done.
The latter bug was masked by the ResourceOwner code, which is something
that should be changed.
Tom Lane [Fri, 25 Mar 2005 16:39:03 +0000 (16:39 +0000)]
Update and copy-edit description of privileges.
Tom Lane [Fri, 25 Mar 2005 16:17:39 +0000 (16:17 +0000)]
Add missing min/max parameters to DefineCustomIntVariable() and
DefineCustomRealVariable(). Thomas Hallgren
Tom Lane [Fri, 25 Mar 2005 16:08:50 +0000 (16:08 +0000)]
Fix to_date to behave reasonably when CC and YY fields are both used.
Karel Zak
Tom Lane [Fri, 25 Mar 2005 00:35:20 +0000 (00:35 +0000)]
Kerberos fixes from Magnus Hagander --- in theory Kerberos 5 auth
should work on Windows now. Also, rename set_noblock to pg_set_noblock;
since it is included in libpq, the former name polluted application
namespace.
Tom Lane [Thu, 24 Mar 2005 23:54:01 +0000 (23:54 +0000)]
Revert ill-conceived change of libpq linkage --- breaks ecpg.
Tom Lane [Thu, 24 Mar 2005 21:50:52 +0000 (21:50 +0000)]
array_map can't use the fn_extra field of the provided fcinfo struct as
its private storage, because that belongs to the function that it is
supposed to call. Per report from Ezequiel Tolnay.
Bruce Momjian [Thu, 24 Mar 2005 19:33:40 +0000 (19:33 +0000)]
Force PG client applications to link to non-shared libpgport before
linking to libpq. This insulates applications from changes in libpq's
usage of libpgport functions.
Backpatched to 8.0.X.
Tom Lane [Thu, 24 Mar 2005 19:15:11 +0000 (19:15 +0000)]
Tweak planner to use a minimum size estimate of 10 pages for a
never-yet-vacuumed relation. This restores the pre-8.0 behavior of
avoiding seqscans during initial data loading, while still allowing
reasonable optimization after a table has been vacuumed. Several
regression test cases revert to 7.4-like behavior, which is probably
a good sign. Per gripes from Keith Browne and others.
Tom Lane [Thu, 24 Mar 2005 17:23:39 +0000 (17:23 +0000)]
Fix python regression testing script to bail out early if language
creation fails ... no point in running the tests.
Tom Lane [Thu, 24 Mar 2005 17:22:44 +0000 (17:22 +0000)]
Adjust plpython to convert \r\n and \r to \n in Python scripts,
per recent discussion concluding that this is the Right Thing. Add
regression test check for this behavior. Michael Fuhr
Bruce Momjian [Thu, 24 Mar 2005 04:37:07 +0000 (04:37 +0000)]
Change Win32 O_SYNC method to O_DSYNC because that is what the method
currently does. This is now the default Win32 wal sync method because
we perfer o_datasync to fsync.
Also, change Win32 fsync to a new wal sync method called
fsync_writethrough because that is the behavior of _commit, which is
what is used for fsync on Win32.
Backpatch to 8.0.X.
Tom Lane [Thu, 24 Mar 2005 02:11:33 +0000 (02:11 +0000)]
Add missing error checking in readdir() loops.
Tom Lane [Wed, 23 Mar 2005 19:39:06 +0000 (19:39 +0000)]
Add note about risks involved in replaying CREATE TABLESPACE commands
from WAL. A couple other grammatical improvements too.
Tom Lane [Wed, 23 Mar 2005 19:06:54 +0000 (19:06 +0000)]
Previous "64-bit fix" for intagg didn't actually work. This is already
fixed properly in CVS tip, but we need a band-aid for back branches.
Per report from Ron Mayer.
Tom Lane [Wed, 23 Mar 2005 00:04:25 +0000 (00:04 +0000)]
WAL must log CREATE and DROP DATABASE operations *without* using any
explicit paths, so that the log can be replayed in a data directory
with a different absolute path than the original had. To avoid forcing
initdb in the 8.0 branch, continue to accept the old WAL log record
types; they will never again be generated however, and the code can be
dropped after the next forced initdb. Per report from Oleg Bartunov.
We still need to think about what it really means to WAL-log CREATE
TABLESPACE commands: we more or less have to put the absolute path
into those, but how to replay in a different context??
Tom Lane [Mon, 21 Mar 2005 16:29:31 +0000 (16:29 +0000)]
Fix quote_ident to use quote_identifier rather than its own, not quite
up-to-speed logic; in particular this will cause it to quote names that
match keywords. Remove unnecessary multibyte cruft from quote_literal
(all backend-internal encodings are 8-bit-safe).
Tom Lane [Fri, 18 Mar 2005 17:33:03 +0000 (17:33 +0000)]
Put 'dump complete' message in the right place, so it comes out where
it's supposed to when --file option is used.
Tom Lane [Fri, 18 Mar 2005 16:16:20 +0000 (16:16 +0000)]
Need to reset local buffer pin counts, not only shared buffer pins,
before we attempt any file deletions in ShutdownPostgres. Per Tatsuo.
Michael Meskes [Fri, 18 Mar 2005 10:01:14 +0000 (10:01 +0000)]
Added patch by Christof Petig <christof@petig-baender.de> to work around gcc bug on powerpc and amd64.
Tom Lane [Fri, 18 Mar 2005 05:24:24 +0000 (05:24 +0000)]
Need to release buffer pins before attempting to drop files during
backend exit. Per report from Bruce.
Tom Lane [Fri, 18 Mar 2005 03:49:19 +0000 (03:49 +0000)]
Treat EPERM as a non-error case when checking to see if old postmaster
is still alive. This improves our odds of not getting fooled by an
unrelated process when checking a stale lock file. Other checks already
in place, plus one newly added in checkDataDir(), ensure that we cannot
attempt to usurp the place of a postmaster belonging to a different userid,
so there is no need to error out. Add comments indicating the importance
of these other checks.
Bruce Momjian [Thu, 17 Mar 2005 17:28:59 +0000 (17:28 +0000)]
Backpatch to 8.0.X, already in HEAD:
Allow Win32 to support the O_SYNC open flag as an wal_sync_method
method.
Bruce Momjian [Wed, 16 Mar 2005 01:49:20 +0000 (01:49 +0000)]
Add missing include for new lc_ctype_is_c() function.
Per Neil.
Bruce Momjian [Wed, 16 Mar 2005 00:03:02 +0000 (00:03 +0000)]
Prevent locale-aware handling of upper, lower, and initcap when the
locale is C.
Backpatch to 8.0.X because some operating systems were throwing errors
for such operations, rather than ignoring the locale when it was C.
Bruce Momjian [Sun, 13 Mar 2005 22:04:45 +0000 (22:04 +0000)]
Increment all major version numbers in 8.0.X to force recompile of
client aplications so 7.4.X releases can be installed on the same
machine as 8.0.X.
Tom Lane [Sat, 12 Mar 2005 21:12:05 +0000 (21:12 +0000)]
Fix ALTER DATABASE RENAME to allow the operation if user is a superuser
who for some reason isn't marked usecreatedb. Per report from Alexander
Pravking. Also fix sloppy coding in have_createdb_privilege().
Neil Conway [Sat, 12 Mar 2005 06:54:31 +0000 (06:54 +0000)]
Some builds (depends on crypto engine support?) of OpenSSL
0.9.7x have EVP_DigestFinal function which which clears all of
EVP_MD_CTX. This makes pgcrypto crash in functions which
re-use one digest context several times: hmac() and crypt()
with md5 algorithm.
Following patch fixes it by carring the digest info around
EVP_DigestFinal and re-initializing cipher.
Marko Kreen.
Tom Lane [Sat, 12 Mar 2005 01:55:15 +0000 (01:55 +0000)]
Fix problem with infinite recursion between write_syslogger_file and
elog if the former has trouble writing its file. Code review for
Magnus' patch to redirect stderr to syslog on Windows (Bruce's version
seems right, but did some minor prettification).
Backpatch both changes to 8.0 branch.
Bruce Momjian [Fri, 11 Mar 2005 21:47:44 +0000 (21:47 +0000)]
Here's the patch to fix a lot of markup errors in the HTML FAQs. Doesn't
change content (at least not supposed to).
Magnus Hagander
Bruce Momjian [Mon, 7 Mar 2005 21:11:07 +0000 (21:11 +0000)]
Properly implement "Response files" for bcc. Add URL's to describe the
feature for Win32 and bcc.
Teodor Sigaev [Sat, 5 Mar 2005 16:17:47 +0000 (16:17 +0000)]
Prevent rank change in case of duplicate search terms
Tom Lane [Thu, 3 Mar 2005 16:47:43 +0000 (16:47 +0000)]
Replace ARC cache management algorithm with the similar but slightly
simpler 2Q algorithm, to avoid possible problems with the pending patent
on ARC. Testing so far suggests that there is little if any performance
loss from doing this.
Note that this patch is going into the 8.0 branch only; a much more
extensive revision is planned for HEAD.
Tom Lane [Tue, 1 Mar 2005 21:15:10 +0000 (21:15 +0000)]
Release proclock immediately in RemoveFromWaitQueue() if it represents
no held locks. This maintains the invariant that proclocks are present
only for procs that are holding or awaiting a lock; when this is not
true, LockRelease will fail. Per report from Stephen Clouse.
Tom Lane [Tue, 1 Mar 2005 01:40:39 +0000 (01:40 +0000)]
Adjust OR indexscan logic to not generate redundant condition-free OR
indexscans involving partial indexes. These would always be dominated
by a simple indexscan on such an index, so there's no point in considering
them. Fixes overoptimism in a patch I applied last October.
Tom Lane [Tue, 1 Mar 2005 00:25:45 +0000 (00:25 +0000)]
Revert the logic for expanding AND/OR conditions in pred_test() to what
it was in 7.4, and add some comments explaining why it has to be this way.
I broke it for OR'd index predicates in a fit of code cleanup last summer.
Per example from Sergey Koshcheyev.
Bruce Momjian [Sun, 27 Feb 2005 22:38:29 +0000 (22:38 +0000)]
Tab indent all actions in bcc32.mak, and do it on win32.mak too for
consistency. Backpatch only bcc32.mak to 8.0.X.
Teodor Sigaev [Sun, 27 Feb 2005 09:28:07 +0000 (09:28 +0000)]
Further fix int64/float8 time/timetz
Teodor Sigaev [Sun, 27 Feb 2005 00:11:35 +0000 (00:11 +0000)]
Further fix time/timetz...
Bruce Momjian [Sat, 26 Feb 2005 18:50:44 +0000 (18:50 +0000)]
Backpatch clarification of PGPASSWORD to 8.0.X.
Bruce Momjian [Fri, 25 Feb 2005 15:57:41 +0000 (15:57 +0000)]
Add linking from /port to bcc makefile.
Teodor Sigaev [Fri, 25 Feb 2005 14:04:39 +0000 (14:04 +0000)]
Fix float8->int64 transformation
Bruce Momjian [Fri, 25 Feb 2005 00:33:45 +0000 (00:33 +0000)]
Backpatch FAQ to 8.0.X.
Tom Lane [Tue, 22 Feb 2005 19:06:35 +0000 (19:06 +0000)]
Document that only a table's owner may TRUNCATE it. Per Keith Worthington.
Bruce Momjian [Tue, 22 Feb 2005 02:56:37 +0000 (02:56 +0000)]
Update initdb locale/encoding documentation description. Backpatch to
8.0.X.
Bruce Momjian [Mon, 21 Feb 2005 21:22:46 +0000 (21:22 +0000)]
Try to get Borland CC to compile.
Backpatch to 8.0.X which doesn't work right now.
Bruce Momjian [Mon, 21 Feb 2005 17:34:10 +0000 (17:34 +0000)]
Update Russian FAQ.
Viktor Vislobokov
Teodor Sigaev [Mon, 21 Feb 2005 14:10:44 +0000 (14:10 +0000)]
Simplify defines
Teodor Sigaev [Mon, 21 Feb 2005 10:47:52 +0000 (10:47 +0000)]
Fix memory leak for timestamp(with and w/o tz) and time indexes
Neil Conway [Mon, 21 Feb 2005 06:12:41 +0000 (06:12 +0000)]
Fix two typos, per report from Hashem Masoud.
Neil Conway [Mon, 21 Feb 2005 02:14:34 +0000 (02:14 +0000)]
Document the "register" and "unregister" pg_ctl subcommands, for use on
Windows. Patch from Magnus Hagander.
Tom Lane [Sat, 19 Feb 2005 23:16:27 +0000 (23:16 +0000)]
New arrangement to always let the bgwriter do checkpoints broke
CHECKPOINT and some other commands in the context of a standalone
backend. Allow a standalone backend to do its own checkpoints.
Tom Lane [Sat, 19 Feb 2005 19:33:23 +0000 (19:33 +0000)]
Ensure that the resolved datatype of any unknown Param is propagated
into the sub-SELECT targetlist when it appears in the context
INSERT INTO foo SELECT $1 ... Per report from Abhijit Menon-Sen.
Tom Lane [Mon, 14 Feb 2005 06:17:59 +0000 (06:17 +0000)]
ALTER LANGUAGE RENAME has never worked. Per Sergey Yatskevich.
Bruce Momjian [Sun, 13 Feb 2005 16:50:54 +0000 (16:50 +0000)]
Print file name and errno string on rmtree failure.
Backpatch to 8.0.X.