XHTML compliance.

diff --git a/login.php b/login.php
index 6aa28df262c20fc5504c317834e5adb20490310d..0a2730fde3bf39ace3e22b9e12ebee080e7a20dd 100755 (executable)
--- a/login.php
+++ b/login.php
@@ -3,7 +3,7 @@
        /**
         * Login screen
         *
-        * $Id: login.php,v 1.33 2007/04/18 14:06:14 mr-russ Exp $
+        * $Id: login.php,v 1.34 2007/04/24 14:49:00 soranzo Exp $
         */
        global $conf;
        
@@ -50,7 +50,6 @@
 </form>
 
 <script type="text/javascript">
-<!--
        var uname = document.login_form.loginUsername;
        var pword = document.login_form.loginPassword;
        if (uname.value == "") {
@@ -58,7 +57,6 @@
        } else {
                pword.focus();
        }
-//-->
 </script>
 
 <?php

diff --git a/tables.php b/tables.php
index b07b5e56964b4630b1d91dafb9986c1415d61844..b096c3415d5f74691cdd2a0d1da1cd2ccae2df69 100644 (file)
--- a/tables.php
+++ b/tables.php
@@ -3,7 +3,7 @@
        /**
         * List tables in a database
         *
-        * $Id: tables.php,v 1.92 2007/04/24 13:48:19 xzilla Exp $
+        * $Id: tables.php,v 1.93 2007/04/24 14:49:00 soranzo Exp $
         */
 
        // Include application functions
@@ -252,18 +252,18 @@
 
                        $attrs = $data->getTableAttributes($_REQUEST['table']);
 
-                       echo "<form action=\"$PHP_SELF\" method=\"post\" name=\"selectform\">\n";
+                       echo "<form action=\"$PHP_SELF\" method=\"post\" id=\"selectform\">\n";
                        if ($attrs->recordCount() > 0) {
                                // JavaScript for select all feature
                                echo "<script type=\"text/javascript\">\n";
-                               echo "<!--\n";
+                               echo "//<![CDATA[\n";
                                echo "  function selectAll() {\n";
-                               echo "          for (var i=0; i<document.selectform.elements.length; i++) {\n";
-                               echo "                  var e = document.selectform.elements[i];\n";
-                               echo "                  if (e.name.indexOf('show') == 0) e.checked = document.selectform.selectall.checked;\n";
+                               echo "          for (var i=0; i<document.getElementById('selectform').elements.length; i++) {\n";
+                               echo "                  var e = document.getElementById('selectform').elements[i];\n";
+                               echo "                  if (e.name.indexOf('show') == 0) e.checked = document.getElementById('selectform').selectall.checked;\n";
                                echo "          }\n";
                                echo "  }\n";
-                               echo "//-->\n";
+                               echo "//]]>\n";
                                echo "</script>\n";
        
                                echo "<table>\n";

diff --git a/tblproperties.php b/tblproperties.php
index 60d3a50a3f28108cc9fb81f558fabbc71823527a..410cc72407bad5203add6f5c1ab99c8d2488ad98 100644 (file)
--- a/tblproperties.php
+++ b/tblproperties.php
@@ -3,7 +3,7 @@
        /**
         * List tables in a database
         *
-        * $Id: tblproperties.php,v 1.76 2007/04/18 13:30:58 ioguix Exp $
+        * $Id: tblproperties.php,v 1.77 2007/04/24 14:49:00 soranzo Exp $
         */
 
        // Include application functions
@@ -662,8 +662,6 @@
                
                $misc->printTable($attrs, $columns, $actions, null, 'attPre');
                
-               echo "<br />\n";
-
                echo "<ul>\n";
                $return_url = urlencode("tblproperties.php?{$misc->href}&amp;table={$_REQUEST['table']}");
                echo "\t<li><a href=\"display.php?{$misc->href}&amp;table=", urlencode($_REQUEST['table']), "&amp;subject=table&amp;return_url={$return_url}&amp;return_desc=",

diff --git a/views.php b/views.php
index 27b5f92df2a4a671c2bca399ac875fd11b881ef8..8ae4d52196819e55b42f29b01b9d1614a7574df6 100644 (file)
--- a/views.php
+++ b/views.php
@@ -3,7 +3,7 @@
        /**
         * Manage views in a database
         *
-        * $Id: views.php,v 1.66 2007/04/23 18:48:06 soranzo Exp $
+        * $Id: views.php,v 1.67 2007/04/24 14:49:00 soranzo Exp $
         */
 
        // Include application functions
@@ -29,21 +29,21 @@
 
                        $attrs = $data->getTableAttributes($_REQUEST['view']);
 
-                       echo "<form action=\"$PHP_SELF\" method=\"post\" name=\"selectform\">\n";
+                       echo "<form action=\"$PHP_SELF\" method=\"post\" id=\"selectform\">\n";
                        if ($attrs->recordCount() > 0) {
                                // JavaScript for select all feature
                                echo "<script type=\"text/javascript\">\n";
-                               echo "<!--\n";
+                               echo "//<![CDATA[\n";
                                echo "  function selectAll() {\n";
-                               echo "          for (var i=0; i<document.selectform.elements.length; i++) {\n";
-                               echo "                  var e = document.selectform.elements[i];\n";
-                               echo "                  if (e.name.indexOf('show') == 0) e.checked = document.selectform.selectall.checked;\n";
+                               echo "          for (var i=0; i<document.getElementById('selectform').elements.length; i++) {\n";
+                               echo "                  var e = document.getElementById('selectform').elements[i];\n";
+                               echo "                  if (e.name.indexOf('show') == 0) e.checked = document.getElementById('selectform').selectall.checked;\n";
                                echo "          }\n";
                                echo "  }\n";
-                               echo "//-->\n";
+                               echo "//]]>\n";
                                echo "</script>\n";
        
-                               echo "<table>\n<tr>";
+                               echo "<table>\n";
 
                                // Output table header
                                echo "<tr><th class=\"data\">{$lang['strshow']}</th><th class=\"data\">{$lang['strcolumn']}</th>";
@@ -61,27 +61,27 @@
                                        // Continue drawing row
                                        $id = (($i % 2) == 0 ? '1' : '2');
                                        echo "<tr>\n";
-                                       echo "<td class=\"data{$id}\" style=\"white-space:nowrap;\">";
+                                       echo "<td class=\"data{$id}\" style=\"white-space: nowrap;\">";
                                        echo "<input type=\"checkbox\" name=\"show[", htmlspecialchars($attrs->fields['attname']), "]\"",
                                                isset($_REQUEST['show'][$attrs->fields['attname']]) ? ' checked="checked"' : '', " /></td>";
-                                       echo "<td class=\"data{$id}\" style=\"white-space:nowrap;\">", $misc->printVal($attrs->fields['attname']), "</td>";
-                                       echo "<td class=\"data{$id}\" style=\"white-space:nowrap;\">", $misc->printVal($data->formatType($attrs->fields['type'], $attrs->fields['atttypmod'])), "</td>";
-                                       echo "<td class=\"data{$id}\" style=\"white-space:nowrap;\">";
+                                       echo "<td class=\"data{$id}\" style=\"white-space: nowrap;\">", $misc->printVal($attrs->fields['attname']), "</td>";
+                                       echo "<td class=\"data{$id}\" style=\"white-space: nowrap;\">", $misc->printVal($data->formatType($attrs->fields['type'], $attrs->fields['atttypmod'])), "</td>";
+                                       echo "<td class=\"data{$id}\" style=\"white-space: nowrap;\">";
                                        echo "<select name=\"ops[{$attrs->fields['attname']}]\">\n";
                                        foreach (array_keys($data->selectOps) as $v) {
                                                echo "<option value=\"", htmlspecialchars($v), "\"", ($v == $_REQUEST['ops'][$attrs->fields['attname']]) ? ' selected="selected"' : '', 
                                                ">", htmlspecialchars($v), "</option>\n";
                                        }
-                                       echo "</select>\n";
-                                       echo "<td class=\"data{$id}\" style=\"white-space:nowrap;\">", $data->printField("values[{$attrs->fields['attname']}]",
+                                       echo "</select></td>\n";
+                                       echo "<td class=\"data{$id}\" style=\"white-space: nowrap;\">", $data->printField("values[{$attrs->fields['attname']}]",
                                                $_REQUEST['values'][$attrs->fields['attname']], $attrs->fields['type']), "</td>";
                                        echo "</tr>\n";
                                        $i++;
                                        $attrs->moveNext();
                                }
                                // Select all checkbox
-                               echo "<tr><td colspan=\"5\"><input type=\"checkbox\" id=\"selectall\" name=\"selectall\" onClick=\"javascript:selectAll()\" /><label for=\"selectall\">{$lang['strselectallfields']}</label></td>";
-                               echo "</table></p>\n";
+                               echo "<tr><td colspan=\"5\"><input type=\"checkbox\" id=\"selectall\" name=\"selectall\" onclick=\"javascript:selectAll()\" /><label for=\"selectall\">{$lang['strselectallfields']}</label></td></tr>";
+                               echo "</table>\n";
                        }
                        else echo "<p>{$lang['strinvalidparam']}</p>\n";