Fixed Bug #1697920: Can't assign a field type/domain of a different schema

We now show all domains that are available in the database, pg_type_is_visible just finds out if the current type is in the search_path.  We just schema qualify all of the types and everything works.

diff --git a/HISTORY b/HISTORY
index 3bc727f33276c87ba404e6380f2f8b7bf448a472..c84d532dbfb85bf484eeafa3735af095606d2245 100644 (file)
--- a/HISTORY
+++ b/HISTORY
@@ -11,6 +11,7 @@ Features
 * You can configure reports db, schema and table names
 
 Bugs
+* Fix inability to assign a field type/domain of a different schema
 * Can't edit a report and set its comment to empty
 * Fix PHP5 Strict mode complaints 
 * Fix IN/NOT IN to accept text input lists 'a','b'

diff --git a/classes/database/Postgres73.php b/classes/database/Postgres73.php
index 52661de9411e4fe713c622d5af1a36ecfdb9a4b3..5e8e294661b0831b56921ec5a86469203240242b 100644 (file)
--- a/classes/database/Postgres73.php
+++ b/classes/database/Postgres73.php
@@ -4,7 +4,7 @@
  * A class that implements the DB interface for Postgres
  * Note: This class uses ADODB and returns RecordSets.
  *
- * $Id: Postgres73.php,v 1.161 2007/01/10 02:01:17 soranzo Exp $
+ * $Id: Postgres73.php,v 1.162 2007/04/18 15:47:51 mr-russ Exp $
  */
 
 // @@@ THOUGHT: What about inherits? ie. use of ONLY???
@@ -1015,7 +1015,7 @@ class Postgres73 extends Postgres72 {
         */
        function getTypes($all = false, $tabletypes = false, $domains = false) {
                if ($all)
-                       $where = 'pg_catalog.pg_type_is_visible(t.oid)';
+                       $where = '1 = 1';
                else
                        $where = "n.nspname = '{$this->_schema}'";
                // Never show system table types