Remove dead NULL-check.
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 26 Jan 2015 16:30:59 +0000 (18:30 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Mon, 26 Jan 2015 16:30:59 +0000 (18:30 +0200)
Per Coverity warning, res-keyset is accessed earlier, so can't be NULL.

results.c

index 45fe0e569059040cab74f93d13c5514c2e6e8e35..7f5964881aacb6dbea3299bfa584ee726d5cd50c 100644 (file)
--- a/results.c
+++ b/results.c
@@ -3000,13 +3000,10 @@ SC_pos_reload_with_tid(StatementClass *stmt, SQLULEN global_ridx, UInt2 *count,
 
            QR_set_position(qres, 0);
            tuple_new = qres->tupleField;
-           if (res->keyset)
-           {
-               if (SQL_CURSOR_KEYSET_DRIVEN == stmt->options.cursor_type &&
-                   strcmp(tuple_new[qres->num_fields - res->num_key_fields].value, tidval))
-                   res->keyset[kres_ridx].status |= SQL_ROW_UPDATED;
-               KeySetSet(tuple_new, qres->num_fields, res->num_key_fields, res->keyset + kres_ridx);
-           }
+           if (SQL_CURSOR_KEYSET_DRIVEN == stmt->options.cursor_type &&
+               strcmp(tuple_new[qres->num_fields - res->num_key_fields].value, tidval))
+               res->keyset[kres_ridx].status |= SQL_ROW_UPDATED;
+           KeySetSet(tuple_new, qres->num_fields, res->num_key_fields, res->keyset + kres_ridx);
            MoveCachedRows(tuple_old, tuple_new, effective_fields, 1);
            ret = SQL_SUCCESS;
        }