Suppress new "may be used uninitialized" warning.
authorNoah Misch <noah@leadboat.com>
Sun, 3 Nov 2024 02:42:52 +0000 (19:42 -0700)
committerNoah Misch <noah@leadboat.com>
Sun, 3 Nov 2024 02:42:56 +0000 (19:42 -0700)
Buildfarm member mamba fails to deduce that the function never uses this
variable without initializing it.  Back-patch to v12, like commit
b412f402d1e020c5dac94f3bf4a005db69519b99.

src/backend/catalog/index.c

index 937a26e5d1c00f76549cd411dd1d7eb948571be9..37693ee6f7b0f10942bfe5539c6acb485236e1ad 100644 (file)
@@ -2802,8 +2802,8 @@ index_update_stats(Relation rel,
                   double reltuples)
 {
    bool        update_stats;
-   BlockNumber relpages;
-   BlockNumber relallvisible;
+   BlockNumber relpages = 0;   /* keep compiler quiet */
+   BlockNumber relallvisible = 0;
    Oid         relid = RelationGetRelid(rel);
    Relation    pg_class;
    ScanKeyData key[1];
@@ -2840,8 +2840,6 @@ index_update_stats(Relation rel,
 
        if (rel->rd_rel->relkind != RELKIND_INDEX)
            visibilitymap_count(rel, &relallvisible, NULL);
-       else                    /* don't bother for indexes */
-           relallvisible = 0;
    }
 
    /*