Fix memory leak pointed out by Coverity.
authorTatsuo Ishii <ishii@sraoss.co.jp>
Tue, 21 Aug 2018 08:33:52 +0000 (17:33 +0900)
committerTatsuo Ishii <ishii@sraoss.co.jp>
Tue, 21 Aug 2018 08:33:52 +0000 (17:33 +0900)
src/main/pgpool_main.c

index d670f2f3d819ffb16cbc2db29f8d10c837972878..2cb9f2313d921cd62f68a81149e321dbbd7b4359 100644 (file)
@@ -3360,9 +3360,7 @@ find_primary_node(void)
        int                     i;
        POOL_NODE_STATUS *status;
        int                     primary = -1;
-       char       *password = get_pgpool_config_user_password(pool_config->sr_check_user,
-                                                                                                                  pool_config->sr_check_password);
-
+       char       *password = NULL;
 
        /* Streaming replication mode? */
        if (!SL_MODE)
@@ -3390,6 +3388,9 @@ find_primary_node(void)
                }
        }
 
+       password = get_pgpool_config_user_password(pool_config->sr_check_user,
+                                                                                          pool_config->sr_check_password);
+
        /*
         * Establish connections to backend
         */