Fix checking of index expressions in CompareIndexInfo().

This code was sloppy about comparison of index columns that
are expressions.  It didn't reliably reject cases where one
index has an expression where the other has a plain column,
and it could index off the start of the attmap array, leading
to a Valgrind complaint (though an actual crash seems unlikely).

I'm not sure that the expression-vs-column sloppiness leads
to any visible problem in practice, because the subsequent
comparison of the two expression lists would reject cases
where the indexes have different numbers of expressions
overall.  Maybe we could falsely match indexes having the
same expressions in different column positions, but it'd
require unlucky contents of the word before the attmap array.
It's not too surprising that no problem has been reported
from the field.  Nonetheless, this code is clearly wrong.

Per bug #18135 from Alexander Lakhin.  Back-patch to all
supported branches.

Discussion: https://postgr.es/m/18135-532f4a755e71e4d2@postgresql.org

diff --git a/src/backend/catalog/index.c b/src/backend/catalog/index.c
index 716de171a456b32671cbe217cf41ee19dbb0f356..3d5adab2c530eae6890a1679c5ff72e9cb4de1c2 100644 (file)
--- a/src/backend/catalog/index.c
+++ b/src/backend/catalog/index.c
@@ -2559,7 +2559,7 @@ CompareIndexInfo(const IndexInfo *info1, const IndexInfo *info2,
 
        /*
         * and columns match through the attribute map (actual attribute numbers
-        * might differ!)  Note that this implies that index columns that are
+        * might differ!)  Note that this checks that index columns that are
         * expressions appear in the same positions.  We will next compare the
         * expressions themselves.
         */
@@ -2568,13 +2568,22 @@ CompareIndexInfo(const IndexInfo *info1, const IndexInfo *info2,
                if (attmap->maplen < info2->ii_IndexAttrNumbers[i])
                        elog(ERROR, "incorrect attribute map");
 
-               /* ignore expressions at this stage */
-               if ((info1->ii_IndexAttrNumbers[i] != InvalidAttrNumber) &&
-                       (attmap->attnums[info2->ii_IndexAttrNumbers[i] - 1] !=
-                        info1->ii_IndexAttrNumbers[i]))
-                       return false;
+               /* ignore expressions for now (but check their collation/opfamily) */
+               if (!(info1->ii_IndexAttrNumbers[i] == InvalidAttrNumber &&
+                         info2->ii_IndexAttrNumbers[i] == InvalidAttrNumber))
+               {
+                       /* fail if just one index has an expression in this column */
+                       if (info1->ii_IndexAttrNumbers[i] == InvalidAttrNumber ||
+                               info2->ii_IndexAttrNumbers[i] == InvalidAttrNumber)
+                               return false;
+
+                       /* both are columns, so check for match after mapping */
+                       if (attmap->attnums[info2->ii_IndexAttrNumbers[i] - 1] !=
+                               info1->ii_IndexAttrNumbers[i])
+                               return false;
+               }
 
-               /* collation and opfamily is not valid for including columns */
+               /* collation and opfamily are not valid for included columns */
                if (i >= info1->ii_NumIndexKeyAttrs)
                        continue;