Revert previous patch to put the shared memory segment on win32

in the Global\ namespace, because it caused permission errors on
a lot of platforms.

We need to come up with something better for 8.4, but for now
revert to the pre-8.3.4 behaviour.

diff --git a/src/backend/port/win32_shmem.c b/src/backend/port/win32_shmem.c
index 970b552043365cf44529cd709111f67594c4f124..893ca609efff19f00bfb820a7e9527d629ab2600 100644 (file)
--- a/src/backend/port/win32_shmem.c
+++ b/src/backend/port/win32_shmem.c
@@ -57,7 +57,13 @@ GetSharedMemName(void)
                elog(FATAL, "could not generate full pathname for datadir %s: %lu",
                         DataDir, GetLastError());
 
-       for (cp = retptr + 18; *cp; cp++)
+       /* 
+        * XXX: Intentionally overwriting the Global\ part here. This was not the
+        * original approach, but putting it in the actual Global\ namespace
+        * causes permission errors in a lot of cases, so we leave it in
+        * the default namespace for now.
+        */
+       for (cp = retptr; *cp; cp++)
                if (*cp == '\\')
                        *cp = '/';