Don't make --enable-cassert turn on RANDOMIZE_ALLOCATED_MEMORY automatically;

it's just too dang expensive.  Per recent discussion, but I just got my
nose rubbed in it again while doing some performance checking.

diff --git a/src/include/pg_config_manual.h b/src/include/pg_config_manual.h
index a3ced75a43b15ecaef1f274f2b751b61381a4de4..6ebb43377f0538f9e88f501f196ac07b9b7fe84d 100644 (file)
--- a/src/include/pg_config_manual.h
+++ b/src/include/pg_config_manual.h
@@ -154,15 +154,6 @@
  *------------------------------------------------------------------------
  */
 
-/*
- * Define this to cause palloc()'d memory to be filled with random data, to
- * facilitate catching code that depends on the contents of uninitialized
- * memory.  Right now, this gets defined automatically if --enable-cassert.
- */
-#ifdef USE_ASSERT_CHECKING
-#define RANDOMIZE_ALLOCATED_MEMORY
-#endif
-
 /*
  * Define this to cause pfree()'d memory to be cleared immediately, to
  * facilitate catching bugs that refer to already-freed values.
@@ -181,6 +172,13 @@
 #define MEMORY_CONTEXT_CHECKING
 #endif
 
+/*
+ * Define this to cause palloc()'d memory to be filled with random data, to
+ * facilitate catching code that depends on the contents of uninitialized
+ * memory.  Caution: this is horrendously expensive.
+ */
+/* #define RANDOMIZE_ALLOCATED_MEMORY */
+
 /*
  * Define this to force all parse and plan trees to be passed through
  * copyObject(), to facilitate catching errors and omissions in