fix tracking of backend platform. needed so that it doesn't think 7.5 running on...

diff --git a/BUGS b/BUGS
index b2179bce8b7a4d7b019fee49ca12d2d4be85356b..93d5b565726a81c7168746699f8799e4879ff8f1 100644 (file)
--- a/BUGS
+++ b/BUGS
@@ -30,7 +30,6 @@ NEEDS TESTING
 * rename function in 7.2 and below doesn't come back to the correct function
 * Fix SQL window parent update to not update any random window
 * Show owner on privileges screen?
- http://devilock.mine.nu/textarea_tab.html
-* fix test for MINGW backend
+* Allows tabs in textareas on IE: http://devilock.mine.nu/textarea_tab.html
 * add help links everywhere.  fix formatting of help links.
 * Deal with named parameters that have ',' in the type name

diff --git a/HISTORY b/HISTORY
index 4011a23a3a1f1abbc0f5828fa430e712526babd1..0b89e1d508f1b94fc09acddaffa30dbb3d7faaa1 100644 (file)
--- a/HISTORY
+++ b/HISTORY
@@ -13,6 +13,7 @@ Features
 * Allow setting schema search path in SQL window
 * Allow filtering find results by object type
 * Show function arguments in find results
+* Support 7.5's named function arguments
 
 Translations
 * Arabic from Zaki

diff --git a/classes/database/ADODB_base.php b/classes/database/ADODB_base.php
index a9152484ac8ed1df29cdba3b7da8a31c36be4095..1a232d59467c0bd1e24ccfd84c4272d324ac1330 100644 (file)
--- a/classes/database/ADODB_base.php
+++ b/classes/database/ADODB_base.php
@@ -3,7 +3,7 @@
 /*
  * Parent class of all ADODB objects.
  *
- * $Id: ADODB_base.php,v 1.18 2004/07/13 09:00:40 chriskl Exp $
+ * $Id: ADODB_base.php,v 1.19 2004/07/19 03:01:53 chriskl Exp $
  */
 
 include_once('./libraries/errorhandler.inc.php');
@@ -12,6 +12,9 @@ include_once('./libraries/adodb/adodb.inc.php');
 class ADODB_base {
 
        var $conn;
+       
+       // The backend platform.  Set to UNKNOWN by default.
+       var $platform = 'UNKNOWN';
 
        /**
         * Base constructor

diff --git a/classes/database/Postgres.php b/classes/database/Postgres.php
index 8acf068e5c4c43de8979fd17e82be8b8f687b5d0..2c4244db0cbc333301e859d4ff1a44e7408c0b60 100755 (executable)
--- a/classes/database/Postgres.php
+++ b/classes/database/Postgres.php
@@ -4,7 +4,7 @@
  * A class that implements the DB interface for Postgres
  * Note: This class uses ADODB and returns RecordSets.
  *
- * $Id: Postgres.php,v 1.240 2004/07/16 16:01:06 soranzo Exp $
+ * $Id: Postgres.php,v 1.241 2004/07/19 03:01:53 chriskl Exp $
  */
 
 // @@@ THOUGHT: What about inherits? ie. use of ONLY???
@@ -2652,7 +2652,7 @@ class Postgres extends BaseDB {
                
                return $this->selectSet($sql);
        }
-       
+
        /**
         * Determines whether or not a user is a super user
         * @param $username The username of the user

diff --git a/classes/database/Postgres75.php b/classes/database/Postgres75.php
index 353e7eea244856fb0070ebc7b424850187ef14c6..d7328fce085e444d00e660718d961f983bedbe51 100755 (executable)
--- a/classes/database/Postgres75.php
+++ b/classes/database/Postgres75.php
@@ -3,7 +3,7 @@
 /**
  * PostgreSQL 7.5 support
  *
- * $Id: Postgres75.php,v 1.14 2004/07/13 09:00:40 chriskl Exp $
+ * $Id: Postgres75.php,v 1.15 2004/07/19 03:01:54 chriskl Exp $
  */
 
 include_once('./classes/database/Postgres74.php');
@@ -443,10 +443,7 @@ class Postgres75 extends Postgres74 {
        }
                
        function hasAlterColumnType() { return true; }
-       function hasTablespaces() { 
-               $platform = $this->getPlatform();
-               return $platform != 'MINGW';
-       }
+       function hasTablespaces() { return $this->platform != 'MINGW'; }
        function hasSignals() { return true; }
        function hasNamedParams() { return true; }
        

diff --git a/libraries/errorhandler.inc.php b/libraries/errorhandler.inc.php
index 0a8b1054a20299ea8f3b2be12d98bc6db7977133..2e7b1d0e4514151179faf5b4f88291db8eb718bb 100644 (file)
--- a/libraries/errorhandler.inc.php
+++ b/libraries/errorhandler.inc.php
@@ -3,7 +3,7 @@
 /**
  * Overrides default ADODB error handler to provide nicer error handling.
  *
- * $Id: errorhandler.inc.php,v 1.15 2004/06/18 14:47:21 soranzo Exp $
+ * $Id: errorhandler.inc.php,v 1.16 2004/07/19 03:01:54 chriskl Exp $
  */
 
 define('ADODB_ERROR_HANDLER','Error_Handler');
@@ -27,7 +27,7 @@ function Error_Handler($dbms, $fn, $errno, $errmsg, $p1=false, $p2=false)
        case 'EXECUTE':
                $sql = $p1;
                $inputparams = $p2;
-
+               
                $s = "<p><b>{$lang['strsqlerror']}</b><br />" . $misc->printVal($errmsg) . "</p>
                      <p><b>{$lang['strinstatement']}</b><br />" . $misc->printVal($sql) . "</p>
                ";

diff --git a/libraries/lib.inc.php b/libraries/lib.inc.php
index 072185c8ff6f6ec21f64680d2cc0f492f926da10..865b9a4c355737c393abd5b01c82cf880caf60ff 100644 (file)
--- a/libraries/lib.inc.php
+++ b/libraries/lib.inc.php
@@ -3,7 +3,7 @@
        /**
         * Function library read in upon startup
         *
-        * $Id: lib.inc.php,v 1.82 2004/07/12 01:35:46 chriskl Exp $
+        * $Id: lib.inc.php,v 1.83 2004/07/19 03:01:54 chriskl Exp $
         */
        
        // Set error reporting level to max
@@ -157,6 +157,7 @@
                // connection.
                require_once('./classes/database/' . $_type . '.php');
                $data = new $_type($_connection->conn);
+               $data->platform = $_connection->platform;
 
                // If schema is defined and database supports schemas, then set the 
                // schema explicitly.