Replace pgwin32_is_junction() with lstat().
authorThomas Munro <tmunro@postgresql.org>
Sat, 6 Aug 2022 00:02:43 +0000 (12:02 +1200)
committerAndrew Dunstan <andrew@dunslane.net>
Thu, 7 Nov 2024 22:59:40 +0000 (09:29 +1030)
commitf95ad555de5623588bcc6e48fe8a3fd50d721216
tree30155fd493e266f4b7ffb0824fdcb607758debe3
parentf2a4a137bb93922a925255665f5a47094ed8c9df
Replace pgwin32_is_junction() with lstat().

Now that lstat() reports junction points with S_IFLNK/S_ISLINK(), and
unlink() can unlink them, there is no need for conditional code for
Windows in a few places.  That was expressed by testing for WIN32 or
S_ISLNK, which we can now constant-fold.

The coding around pgwin32_is_junction() was a bit suspect anyway, as we
never checked for errors, and we also know that errors can be spuriously
reported because of transient sharing violations on this OS.  The
lstat()-based code has handling for that.

This also reverts 4fc6b6ee on master only.  That was done because
lstat() didn't previously work for symlinks (junction points), but now
it does.

Tested-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/CA%2BhUKGLfOOeyZpm5ByVcAt7x5Pn-%3DxGRNCvgiUPVVzjFLtnY0w%40mail.gmail.com
(cherry picked from commit 5fc88c5d53e43fa7dcea93499d230a0bf70f4f77)

Author: Thomas Munro <tmunro@postgresql.org>
Author: Alexandra Wang <alexandra.wang.oss@gmail.com>
src/backend/backup/basebackup.c
src/backend/commands/tablespace.c
src/backend/storage/file/fd.c
src/backend/utils/adt/misc.c
src/bin/pg_checksums/pg_checksums.c
src/bin/pg_rewind/file_ops.c
src/common/file_utils.c
src/include/port.h
src/include/port/win32_port.h
src/port/dirmod.c