smgr: Make SMgrRelation initialization safer against errors
authorAndres Freund <andres@anarazel.de>
Tue, 18 Mar 2025 17:43:10 +0000 (13:43 -0400)
committerAndres Freund <andres@anarazel.de>
Tue, 18 Mar 2025 17:44:10 +0000 (13:44 -0400)
commitee578921b60ef9a14eaea54b608549e4f8b14f26
treed3fbb4800eeda5ea1f5114eb1fd501f6d13d657b
parent09ef2f8df1cd746d711ffd916bdd2e9526c51b65
smgr: Make SMgrRelation initialization safer against errors

In case the smgr_open callback failed, the ->pincount field would not be
initialized and the relation would not be put onto the unpinned_relns list.

This buglet was introduced in 21d9c3ee4ef7, in 17.

Discussion: https://postgr.es/m/3vae7l5ozvqtxmd7rr7zaeq3qkuipz365u3rtim5t5wdkr6f4g@vkgf2fogjirl
Backpatch-through: 17
src/backend/storage/smgr/smgr.c