Count SP-GiST index scans in pg_stat statistics.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 27 Aug 2021 23:42:42 +0000 (19:42 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 27 Aug 2021 23:42:42 +0000 (19:42 -0400)
commitdbb239d518eef791ec6e8f2180e71078e7f89e38
treef76c62058bca3aa43fb6c320bd52115ebd04fea9
parent53597fd6c3cc2042cad9909b962459fa26c26e20
Count SP-GiST index scans in pg_stat statistics.

Somehow, spgist overlooked the need to call pgstat_count_index_scan().
Hence, pg_stat_all_indexes.idx_scan and equivalent columns never
became nonzero for an SP-GiST index, although the related per-tuple
counters worked fine.

This fix works a bit differently from other index AMs, in that the
counter increment occurs in spgrescan not spggettuple/spggetbitmap.
It looks like this won't make the user-visible semantics noticeably
different, so I won't go to the trouble of introducing an is-this-
the-first-call flag just to make the counter bumps happen in the
same places.

Per bug #17163 from Christian Quest.  Back-patch to all supported
versions.

Discussion: https://postgr.es/m/17163-b8c5cc88322a5e92@postgresql.org
src/backend/access/spgist/spgscan.c