Avoid ERROR at ON COMMIT DELETE ROWS after relhassubclass=f.
authorNoah Misch <noah@leadboat.com>
Sun, 20 Apr 2025 15:28:48 +0000 (08:28 -0700)
committerNoah Misch <noah@leadboat.com>
Sun, 20 Apr 2025 15:28:52 +0000 (08:28 -0700)
commitd0a049987e5a0aab8bc79af889ff12349a325c97
tree8befbc716c905d4f0d9703c049eb38e2e5ce637c
parent065ce49a10e0722df809935504bc7814e94a04dc
Avoid ERROR at ON COMMIT DELETE ROWS after relhassubclass=f.

Commit 7102070329d8147246d2791321f9915c3b5abf31 fixed a similar bug, but
it missed the case of database-wide ANALYZE ("use_own_xacts" mode).
Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 changed consequences
from silent discard of a pg_class stats (relpages et al.) update to
ERROR "tuple to be updated was already modified".  Losing a relpages
update of an ON COMMIT DELETE ROWS table was negligible, but a
COMMIT-time error isn't negligible.  Back-patch to v13 (all supported
versions).

Reported-by: Richard Guo <guofenglinux@gmail.com
Reported-by: Robins Tharakan <tharakan@gmail.com>
Discussion: https://postgr.es/m/CAMbWs4-XwMKMKJ_GT=p3_-_=j9rQSEs1FbDFUnW9zHuKPsPNEQ@mail.gmail.com
Backpatch-through: 13
src/backend/commands/vacuum.c
src/test/regress/expected/maintain_every.out [new file with mode: 0644]
src/test/regress/parallel_schedule
src/test/regress/sql/maintain_every.sql [new file with mode: 0644]