Fix several datatype input functions that were allowing unused bytes in their
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 11 Apr 2008 22:52:05 +0000 (22:52 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 11 Apr 2008 22:52:05 +0000 (22:52 +0000)
commitc846f7ca8a700f2f5418820a224cf59574ca4f04
tree81d51b519c0bb7b3e89a9f651c9af299a1b09521
parent00b1827ae179fb36edaefc3d16775b9a1e65aad1
Fix several datatype input functions that were allowing unused bytes in their
results to contain uninitialized, unpredictable values.  While this was okay
as far as the datatypes themselves were concerned, it's a problem for the
parser because occurrences of the "same" literal might not be recognized as
equal by datumIsEqual (and hence not by equal()).  It seems sufficient to fix
this in the input functions since the only critical use of equal() is in the
parser's comparisons of ORDER BY and DISTINCT expressions.
Per a trouble report from Marc Cousin.

Patch all the way back.  Interestingly, array_in did not have the bug before
8.2, which may explain why the issue went unnoticed for so long.
contrib/ltree/ltree_io.c
src/backend/utils/adt/arrayfuncs.c
src/backend/utils/adt/geo_ops.c
src/backend/utils/adt/tsquery.c