Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h"
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 23 Jan 2024 08:38:07 +0000 (10:38 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Tue, 23 Jan 2024 08:53:23 +0000 (10:53 +0200)
commitc5a6d5337170a133490c91d7f6d27ac25c47480b
tree9ee52145a6f24d7d22cda8d2be688cc508798a18
parentcae25d110e0898df2df4fe31fdc45208554ac908
Revert "libpqwalreceiver: Convert to libpq-be-fe-helpers.h"

This reverts commit 728f86fec65537eade8d9e751961782ddb527934.

The signal handling was a few bricks shy of a load in that commit,
which made the walreceiver non-responsive to SIGTERM while it was
waiting for the connection to be established. That prevented a standby
from being promoted.

Since it was non-essential refactoring, let's revert it to make v16
work the same as earlier releases. I reverted it in 'master' too, to
keep the branches in sync. The refactoring was a good idea as such,
but it needs a bit more work. Once we have developed a complete patch
with this issue fixed, let's re-apply that to 'master'.

Reported-by: Kyotaro Horiguchi
Backpatch-through: 16
Discussion: https://www.postgresql.org/message-id/20231231.200741.1078989336605759878.horikyota.ntt@gmail.com
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c