Fix privilege checks in pg_stats_ext and pg_stats_ext_exprs.
authorNathan Bossart <nathan@postgresql.org>
Mon, 6 May 2024 14:00:19 +0000 (09:00 -0500)
committerNathan Bossart <nathan@postgresql.org>
Mon, 6 May 2024 14:00:19 +0000 (09:00 -0500)
commitc3425383ba67ae6ecaddc8896025a91faadb430a
tree3c2222c50a64ff28ea1a8f4a608eabf2d5c40b49
parent0288acb0c61f6b0d68d3a625c92bcc54a655442e
Fix privilege checks in pg_stats_ext and pg_stats_ext_exprs.

The catalog view pg_stats_ext fails to consider privileges for
expression statistics.  The catalog view pg_stats_ext_exprs fails
to consider privileges and row-level security policies.  To fix,
restrict the data in these views to table owners or roles that
inherit privileges of the table owner.  It may be possible to apply
less restrictive privilege checks in some cases, but that is left
as a future exercise.  Furthermore, for pg_stats_ext_exprs, do not
return data for tables with row-level security enabled, as is
already done for pg_stats_ext.

On the back-branches, a fix-CVE-2024-4317.sql script is provided
that will install into the "share" directory.  This file can be
used to apply the fix to existing clusters.

Bumps catversion on 'master' branch only.

Reported-by: Lukas Fittl
Reviewed-by: Noah Misch, Tomas Vondra, Tom Lane
Security: CVE-2024-4317
Backpatch-through: 14
doc/src/sgml/catalogs.sgml
src/backend/catalog/Makefile
src/backend/catalog/fix-CVE-2024-4317.sql [new file with mode: 0644]
src/backend/catalog/system_views.sql
src/test/regress/expected/rules.out
src/test/regress/expected/stats_ext.out
src/test/regress/sql/stats_ext.sql