Flush Memoize cache when non-key parameters change, take 2
authorDavid Rowley <drowley@postgresql.org>
Wed, 24 Nov 2021 10:29:56 +0000 (23:29 +1300)
committerDavid Rowley <drowley@postgresql.org>
Wed, 24 Nov 2021 10:29:56 +0000 (23:29 +1300)
commitc2dc7b9e15039ce90c0a631ff291feb81d2c8051
tree07729c689c4f0a51b2dccd4d679edee283c194a6
parent0e681fa458750b08a5c7885820320fb85cd9ddf1
Flush Memoize cache when non-key parameters change, take 2

It's possible that a subplan below a Memoize node contains a parameter
from above the Memoize node.  If this parameter changes then cache entries
may become out-dated due to the new parameter value.

Previously Memoize was mistakenly not aware of this.  We fix this here by
flushing the cache whenever a parameter that's not part of the cache
key changes.

Bug: #17213
Reported by: Elvis Pranskevichus
Author: David Rowley
Discussion: https://postgr.es/m/17213-988ed34b225a2862@postgresql.org
Backpatch-through: 14, where Memoize was added
12 files changed:
src/backend/executor/nodeMemoize.c
src/backend/nodes/bitmapset.c
src/backend/nodes/copyfuncs.c
src/backend/nodes/outfuncs.c
src/backend/nodes/readfuncs.c
src/backend/optimizer/plan/createplan.c
src/backend/optimizer/util/clauses.c
src/include/nodes/execnodes.h
src/include/nodes/plannodes.h
src/include/optimizer/clauses.h
src/test/regress/expected/memoize.out
src/test/regress/sql/memoize.sql