Prevent underflow in KeepLogSeg().
authorNathan Bossart <nathan@postgresql.org>
Thu, 27 Apr 2023 20:43:48 +0000 (13:43 -0700)
committerNathan Bossart <nathan@postgresql.org>
Thu, 27 Apr 2023 21:32:55 +0000 (14:32 -0700)
commitbe40dd63e00d4ccb1bc10cab5c086a6e544c3a30
tree33322283013f162927777df9f7c300a34624aa97
parentde2dfa0538f4b2c75c5368c21cf4f187dc8bb501
Prevent underflow in KeepLogSeg().

The call to XLogGetReplicationSlotMinimumLSN() might return a
greater LSN than the one given to the function.  Subsequent segment
number calculations might then underflow, which could result in
unexpected behavior when removing or recyling WAL files.  This was
introduced with max_slot_wal_keep_size in c655077639.  To fix, skip
the block of code for replication slots if the LSN is greater.

Reported-by: Xu Xingwang
Author: Kyotaro Horiguchi
Reviewed-by: Junwang Zhao
Discussion: https://postgr.es/m/17903-4288d439dee856c6%40postgresql.org
Backpatch-through: 13
src/backend/access/transam/xlog.c