Fix bug in detecting concurrent page splits in GiST insert
authorHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 20 Jan 2021 09:58:03 +0000 (11:58 +0200)
committerHeikki Linnakangas <heikki.linnakangas@iki.fi>
Wed, 20 Jan 2021 09:58:25 +0000 (11:58 +0200)
commitb8403d140f4e7d753d21116c0fa79dc4ca5ca5cb
tree664cedcb51870a7a144b52fe79b63ccff0ab7e7c
parent31e0f9d76bb0196b92f6870a8e1e3e2a4e5e2b28
Fix bug in detecting concurrent page splits in GiST insert

In commit 9eb5607e699, I got the condition on checking for split or
deleted page wrong: I used && instead of ||. The comment correctly said
"concurrent split _or_ deletion".

As a result, GiST insertion could miss a concurrent split, and insert to
wrong page. Duncan Sands demonstrated this with a test script that did a
lot of concurrent inserts.

Backpatch to v12, where this was introduced. REINDEX is required to fix
indexes that were affected by this bug.

Backpatch-through: 12
Reported-by: Duncan Sands
Discussion: https://www.postgresql.org/message-id/a9690483-6c6c-3c82-c8ba-dc1a40848f11%40deepbluecap.com
src/backend/access/gist/gist.c