SQL/JSON: Improve some error messages
authorAmit Langote <amitlan@postgresql.org>
Thu, 18 Apr 2024 05:33:47 +0000 (14:33 +0900)
committerAmit Langote <amitlan@postgresql.org>
Thu, 18 Apr 2024 05:45:48 +0000 (14:45 +0900)
commitb4fad46b6bc8a9bf46ff689bcb1bd4edf8f267af
tree48accd814bfb6c712699b8f26734fbf06c949b3e
parent40126ac68f2ff96351cd6071350eb2d5cbd50145
SQL/JSON: Improve some error messages

This improves some error messages emitted by SQL/JSON query functions
by mentioning column name when available, such as when they are
invoked as part of evaluating JSON_TABLE() columns.  To do so, a new
field column_name is added to both JsonFuncExpr and JsonExpr that is
only populated when creating those nodes for transformed JSON_TABLE()
columns.

While at it, relevant error messages are reworded for clarity.

Reported-by: Jian He <jian.universality@gmail.com>
Suggested-by: Jian He <jian.universality@gmail.com>
Discussion: https://postgr.es/m/CACJufxG_e0QLCgaELrr2ZNz7AxPeGCNKAORe3fHtFCQLsH4J4Q@mail.gmail.com
src/backend/executor/execExprInterp.c
src/backend/parser/parse_expr.c
src/backend/parser/parse_jsontable.c
src/backend/utils/adt/jsonpath_exec.c
src/include/nodes/parsenodes.h
src/include/nodes/primnodes.h
src/include/utils/jsonpath.h
src/test/regress/expected/sqljson_jsontable.out
src/test/regress/expected/sqljson_queryfuncs.out
src/test/regress/sql/sqljson_jsontable.sql