Fix incorrect return value for pg_size_pretty(bigint)
authorDavid Rowley <drowley@postgresql.org>
Sun, 28 Jul 2024 10:22:52 +0000 (22:22 +1200)
committerDavid Rowley <drowley@postgresql.org>
Sun, 28 Jul 2024 10:22:52 +0000 (22:22 +1200)
commitb181062aa5727a013c96b64476f884c992b5068d
tree29821bfd371503d1ef124606fb76f197abaa41e2
parent1e666fd7c6d3bff658cdbad02b4e7bb77dde391d
Fix incorrect return value for pg_size_pretty(bigint)

pg_size_pretty(bigint) would return the value in bytes rather than PB
for the smallest-most bigint value.  This happened due to an incorrect
assumption that the absolute value of -9223372036854775808 could be
stored inside a signed 64-bit type.

Here we fix that by instead storing that value in an unsigned 64-bit type.

This bug does exist in versions prior to 15 but the code there is
sufficiently different and the bug seems sufficiently non-critical that
it does not seem worth risking backpatching further.

Author: Joseph Koshakow <koshy44@gmail.com>
Discussion: https://postgr.es/m/CAAvxfHdTsMZPWEHUrZ=h3cky9Ccc3Mtx2whUHygY+ABP-mCmUw@mail.gmail.com
Backpatch-through: 15
src/backend/utils/adt/dbsize.c
src/test/regress/expected/dbsize.out
src/test/regress/sql/dbsize.sql