Revert "Allow parallel workers to cope with a newly-created session user ID."
authorTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Aug 2024 00:55:25 +0000 (20:55 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Thu, 1 Aug 2024 00:55:25 +0000 (20:55 -0400)
commitafbf32fa1aa87f710b623cbdf746c55b4799574e
tree10bb57940f0cd1bee68b3328bdccc6642ae84994
parent48536305370acd75c6264fcefec7fae7af8c5440
Revert "Allow parallel workers to cope with a newly-created session user ID."

This reverts commit 48536305370acd75c6264fcefec7fae7af8c5440.

Some buildfarm animals are failing with "cannot change
"client_encoding" during a parallel operation".  It looks like
assign_client_encoding is unhappy at being asked to roll back a
client_encoding setting after a parallel worker encounters a
failure.  There must be more to it though: why didn't I see this
during local testing?  In any case, it's clear that moving the
RestoreGUCState() call is not as side-effect-free as I thought.
Given that the bug f5f30c22e intended to fix has gone unreported
for years, it's not something that's urgent to fix; I'm not
willing to risk messing with it further with only days to our
next release wrap.
src/backend/access/transam/parallel.c
src/backend/commands/variable.c
src/test/regress/expected/select_parallel.out
src/test/regress/sql/select_parallel.sql