Further tweaking of PG_SYSROOT heuristics for macOS.
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 20 Jan 2021 17:07:23 +0000 (12:07 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 20 Jan 2021 17:07:23 +0000 (12:07 -0500)
commit9d23c15a034ba163ae1045b945954e8e1bcfc72a
treea120b6e919e1d9a4a5c8b1ca2999aab9ff79cb94
parentc2dc1a79767a0f947e1145f82eb65dfe4360d25f
Further tweaking of PG_SYSROOT heuristics for macOS.

It emerges that in some phases of the moon (perhaps to do with
directory entry order?), xcrun will report that the SDK path is
  /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk
which is normally a symlink to a version-numbered sibling directory.
Our heuristic to skip non-version-numbered pathnames was rejecting
that, which is the wrong thing to do.  We'd still like to end up
with a version-numbered PG_SYSROOT value, but we can have that by
dereferencing the symlink.

Like the previous fix, back-patch to all supported versions.

Discussion: https://postgr.es/m/522433.1611089678@sss.pgh.pa.us
src/template/darwin