Add isExtend to the parameters of the buffer_read_start and buffer_read_done
authorTom Lane <tgl@sss.pgh.pa.us>
Sun, 22 Mar 2009 22:39:05 +0000 (22:39 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Sun, 22 Mar 2009 22:39:05 +0000 (22:39 +0000)
commit863e97d71298bf7cbcc98355ef5f36178608dca3
tree35acc3913c32a44c5fa9d75cecfbd5813ea65860
parentebc27fc394d76faa4cf512686d0a87434e171912
Add isExtend to the parameters of the buffer_read_start and buffer_read_done
DTrace probes, so that ordinary reads can be distinguished from relation
extension operations.  Move buffer_read_start probe to before the
smgrnblocks() call that's needed in the isExtend case, since really that step
should be charged as part of the time needed for the extension operation.
(This makes it slightly harder to match the read_start with the associated
read_done, since now you can't match them on blockNumber, but it should still
be possible since isExtend operations on the same relation can never be
interleaved.)  Per recent discussion.

In passing, add the page identity (forkNum/blockNum) to the parameters of the
buffer_flush_start/buffer_flush_done probes, which were unaccountably lacking
the info.
src/backend/storage/buffer/bufmgr.c
src/backend/utils/probes.d