Fix illegal attribute propagation in LLVM JIT.
authorThomas Munro <tmunro@postgresql.org>
Tue, 9 Apr 2024 22:46:15 +0000 (10:46 +1200)
committerThomas Munro <tmunro@postgresql.org>
Wed, 10 Apr 2024 00:14:04 +0000 (12:14 +1200)
commit74992929a79e2606fbc4d579c3fad04a890eda04
tree243707105c39f74ca2631774c1a8b10fca2e2da8
parent6304ee667759852083197c425668ae381ba82c22
Fix illegal attribute propagation in LLVM JIT.

Commit 72559438 started copying more attributes from AttributeTemplate
to the functions we generate on the fly.  In the case of deform
functions, which return void, this meant that "noundef", from
AttributeTemplate's return value (a Datum) was copied to a void type.
Older LLVM releases were OK with that, but LLVM 18 crashes.

Update our llvm_copy_attributes() function to skip copying the attribute
for the return value, if the target function returns void.

Thanks to Dmitry Dolgov for help chasing this down.

Back-patch to all supported releases, like 72559438.

Reported-by: Pavel Stehule <pavel.stehule@gmail.com>
Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com>
Discussion: https://postgr.es/m/CAFj8pRACpVFr7LMdVYENUkScG5FCYMZDDdSGNU-tch%2Bw98OxYg%40mail.gmail.com
src/backend/jit/llvm/llvmjit.c