Move I/O before the index_update_stats() buffer lock region.
authorNoah Misch <noah@leadboat.com>
Sat, 2 Nov 2024 16:04:55 +0000 (09:04 -0700)
committerNoah Misch <noah@leadboat.com>
Sat, 2 Nov 2024 16:05:04 +0000 (09:05 -0700)
commit6d5b4031b927328e548088ebcc24781223b3b803
treeafe2642c3ab682edaa84649b9b884ada6b3158ec
parent27642d89081ec5ec2949b1a52cb707adce5798e8
Move I/O before the index_update_stats() buffer lock region.

Commit a07e03fd8fa7daf4d1356f7cb501ffe784ea6257 enlarged the work done
here under the pg_class heap buffer lock.  Two preexisting actions are
best done before holding that lock.  Both RelationGetNumberOfBlocks()
and visibilitymap_count() do I/O, and the latter might exclusive-lock a
visibility map buffer.  Moving these reduces contention and risk of
undetected LWLock deadlock.  Back-patch to v12, like that commit.

Discussion: https://postgr.es/m/20241031200139.b4@rfd.leadboat.com
src/backend/catalog/index.c