Fix use-after-free bug when renaming constraints
authorMichael Paquier <michael@paquier.xyz>
Mon, 17 Dec 2018 03:43:00 +0000 (12:43 +0900)
committerMichael Paquier <michael@paquier.xyz>
Mon, 17 Dec 2018 03:43:00 +0000 (12:43 +0900)
commit67915fb8e51692ae92622696ad03e933be224bf2
tree0bd1c15c7c190f029a43cc368af1ff697832c716
parentb13fd344c5fce6a2f95b758e97b79eb00adf2731
Fix use-after-free bug when renaming constraints

This is an oversight from recent commit b13fd344.  While on it, tweak
the previous test with a better name for the renamed primary key.

Detected by buildfarm member prion which forces relation cache release
with -DRELCACHE_FORCE_RELEASE.  Back-patch down to 9.4 as the previous
commit.
src/backend/commands/tablecmds.c
src/test/regress/expected/alter_table.out
src/test/regress/sql/alter_table.sql