Rearrange dblink's dblink_build_sql_insert() and related routines to open and
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 14 Jun 2010 20:50:11 +0000 (20:50 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 14 Jun 2010 20:50:11 +0000 (20:50 +0000)
commit5ab2c669cb37e4a5d8cf2c112559ed0c5e9359c1
tree5c3082d4d8a289fc11c7da39a9e84e924b3addf3
parent6742c60153591f018030db57f356d4a78c38f384
Rearrange dblink's dblink_build_sql_insert() and related routines to open and
lock the target relation just once per SQL function call.  The original coding
obtained and released lock several times per call.  Aside from saving a
not-insignificant number of cycles, this eliminates possible race conditions
if someone tries to modify the relation's schema concurrently.  Also
centralize locking and permission-checking logic.

Problem noted while investigating a trouble report from Robert Voinea --- his
problem is still to be fixed, though.
contrib/dblink/dblink.c