Avoid assuming that struct varattrib_pointer doesn't get padded by the
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Oct 2007 16:25:56 +0000 (16:25 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 1 Oct 2007 16:25:56 +0000 (16:25 +0000)
commit5a2a2346e0f92a49f46988d929bbb30e2c828f00
treefb14cbdc0f8e2904a78f88538a90d84f5114db5a
parent0d61bc072d98b308d1e5e5a1b19115ada1c8904d
Avoid assuming that struct varattrib_pointer doesn't get padded by the
compiler --- at least on ARM, it does.  I suspect that the varvarlena patch
has been creating larger-than-intended toast pointers all along on ARM,
but it wasn't exposed until the latest tweak added some Asserts that
calculated the expected size in a different way.  We could probably have
fixed this by adding __attribute__((packed)) as is done for ItemPointerData,
but struct varattrib_pointer isn't really all that useful anyway, so it
seems cleanest to just get rid of it and have only struct varattrib_1b_e.
Per results from buildfarm member quagga.
src/backend/access/heap/tuptoaster.c
src/include/postgres.h