postgres_fdw: Minor cleanup for pgfdw_abort_cleanup().
authorEtsuro Fujita <efujita@postgresql.org>
Fri, 25 Mar 2022 06:30:00 +0000 (15:30 +0900)
committerEtsuro Fujita <efujita@postgresql.org>
Fri, 25 Mar 2022 06:30:00 +0000 (15:30 +0900)
commit56566835039ac5eed70f188518cef1a7ea0971b2
tree11dba5eb4e8b705e01afe12ab6776747946755ba
parentad8759bea06d2a0cac033f5ba551011663d9e716
postgres_fdw: Minor cleanup for pgfdw_abort_cleanup().

Commit 85c696112 introduced this function to deduplicate code in the
transaction callback functions, but the SQL command passed as an
argument to it was useless when it returned before aborting a remote
transaction using the command.  Modify pgfdw_abort_cleanup() so that it
constructs the command when/if necessary, as before, removing the
argument from it.  Also update comments in pgfdw_abort_cleanup() and one
of the calling functions.

Etsuro Fujita, reviewed by David Zhang.

Discussion: https://postgr.es/m/CAPmGK158hrd%3DZfXmgkmNFHivgh18e4oE2Gz151C2Q4OBDjZ08A%40mail.gmail.com
contrib/postgres_fdw/connection.c