Fix performance regression in pg_strtointNN_safe functions
authorDavid Rowley <drowley@postgresql.org>
Wed, 2 Aug 2023 00:06:08 +0000 (12:06 +1200)
committerDavid Rowley <drowley@postgresql.org>
Wed, 2 Aug 2023 00:06:08 +0000 (12:06 +1200)
commit4e2e75cd29eb7bc591afe30fd7425629fe2c5a5d
tree087969c80f317d23140512487fc0292ad2f241b2
parentb25acc302524cf61bee46e1aad5bebb276449270
Fix performance regression in pg_strtointNN_safe functions

Between 6fcda9aba and 1b6f632a3, the pg_strtoint functions became quite
a bit slower in v16, despite efforts in 6b423ec67 to speed these up.

Since the majority of cases for these functions will only contain
base-10 digits, perhaps prefixed by a '-', it makes sense to have a
special case for this and just fall back on the more complex version
which processes hex, octal, binary and underscores if the fast path
version fails to parse the string.

While we're here, update the header comments for these functions to
mention that hex, octal and binary formats along with underscore
separators are now supported.

Author: Andres Freund, David Rowley
Reported-by: Masahiko Sawada
Reviewed-by: Dean Rasheed, John Naylor
Discussion: https://postgr.es/m/CAD21AoDvDmUQeJtZrau1ovnT_smN940%3DKp6mszNGK3bq9yRN6g%40mail.gmail.com
Backpatch-through: 16, where 6fcda9aba and 1b6f632a3 were added
src/backend/utils/adt/numutils.c