Revise large-object access routines to avoid running with CurrentMemoryContext
authorTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Apr 2006 00:34:57 +0000 (00:34 +0000)
committerTom Lane <tgl@sss.pgh.pa.us>
Wed, 26 Apr 2006 00:34:57 +0000 (00:34 +0000)
commit486f994be7993e971ac22b207504f7c035793668
tree23bcd5a8f40652090fd2fc6ffb291a63c4cc4999
parentd2896a9ed14387912bffb6f7ed188aca0a245e71
Revise large-object access routines to avoid running with CurrentMemoryContext
set to the large object context ("fscxt"), as this is inevitably a source of
transaction-duration memory leaks.  Not sure why we'd not noticed it before;
maybe people weren't touching a whole lot of LOs in the same transaction
before the 8.1 pg_dump changes.  Per report from Wayne Conrad.

Backpatched as far as 8.1, but the problem doubtless goes all the way back.
I'm disinclined to spend the time to try to verify that the older branches
would still work if patched, seeing that this code was significantly modified
for 8.0 and again for 8.1, and that we don't have any trouble reports before
8.1.  (Maybe the leaks were smaller before?)
src/backend/libpq/be-fsstubs.c
src/backend/storage/large_object/inv_api.c
src/include/storage/large_object.h