Fix determination of broken LSN in OVERWRITTEN_CONTRECORD
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 26 Nov 2021 14:14:27 +0000 (11:14 -0300)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Fri, 26 Nov 2021 14:14:27 +0000 (11:14 -0300)
commit44bd3ed332d6ad3207f38b3b6deb6083f0baddf5
tree4dd1a3b3bf2a758bd219c6a50b5fa42f2b67aecb
parent4597fd78d6dea2235cb948ea036c2d61057c415c
Fix determination of broken LSN in OVERWRITTEN_CONTRECORD

In commit ff9f111bce24 I mixed up inconsistent definitions of the LSN of
the first record in a page, when the previous record ends exactly at the
page boundary.  The correct LSN is adjusted to skip the WAL page header;
I failed to use that when setting XLogReaderState->overwrittenRecPtr,
so at WAL replay time VerifyOverwriteContrecord would refuse to let
replay continue past that record.

Backpatch to 10.  9.6 also contains this bug, but it's no longer being
maintained.

Discussion: https://postgr.es/m/45597.1637694259@sss.pgh.pa.us
src/backend/access/transam/xlogreader.c