tests: Cope with WARNINGs during failed CREATE DB on windows
authorAndres Freund <andres@anarazel.de>
Wed, 2 Apr 2025 11:08:10 +0000 (07:08 -0400)
committerAndres Freund <andres@anarazel.de>
Wed, 2 Apr 2025 11:51:48 +0000 (07:51 -0400)
commit43dca8a11624d02dde2b4bd348d77b7045c0dfbc
tree3da45835883b77cb1c7e633c29971a255088d0d8
parenteec0040c4bcd650993bb058ebdf61ab94171fda4
tests: Cope with WARNINGs during failed CREATE DB on windows

The test added in 93bc3d75d8e sometimes fails on windows, due to warnings like
WARNING:  some useless files may be left behind in old database directory "base/16514"

The reason for that is createdb_failure_callback() does not ensure that there
are no open file descriptors for files in the partially created,
to-be-dropped, database. We do take care in dropdb(), but that involves
waiting for checkpoints and a ProcSignalBarrier, which we probably don't want
to do in an error callback.  This should probably be fixed one day, but for
now 001_aio.pl needs to cope.

Per buildfarm animals fairywren and drongo.

Discussion: https://postgr.es/m/uc62i6vi5gd4bi6wtjj5poadqxolgy55e7ihkmf3mthjegb6zl@zqo7xez7sc2r
src/test/modules/test_aio/t/001_aio.pl