Cleanup minor pg_dump memory leaks
authorStephen Frost <sfrost@snowman.net>
Thu, 6 Dec 2018 16:11:21 +0000 (11:11 -0500)
committerStephen Frost <sfrost@snowman.net>
Thu, 6 Dec 2018 16:11:21 +0000 (11:11 -0500)
commit369d494a4f5c1494a46adcf5c56f5462a83ef20d
treec66e680068cb0a97b6641d783339424c977e1d94
parenta243c55326686b284fbe2c7b70f06d8a022b7dcc
Cleanup minor pg_dump memory leaks

In dumputils, we may have successfully parsed the acls when we discover
that we can't parse the reverse ACLs and then return- check and free
aclitems if that happens.

In dumpTableSchema, move ftoptions and srvname under the relkind !=
RELKIND_VIEW branch (since they're only used there) and then check if
they've been allocated and, if so, free them at the end of that block.

Pointed out by Pavel Raiskup, though I didn't use those patches.

Discussion: https://postgr.es/m/2183976.vkCJMhdhmF@nb.usersys.redhat.com
src/bin/pg_dump/dumputils.c
src/bin/pg_dump/pg_dump.c