Fix ALTER DEFAULT PRIVILEGES with duplicated objects
authorMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:39:14 +0000 (11:39 +0900)
committerMichael Paquier <michael@paquier.xyz>
Wed, 20 Jan 2021 02:39:14 +0000 (11:39 +0900)
commit31e0f9d76bb0196b92f6870a8e1e3e2a4e5e2b28
treea466ed64f8abd55bb6d621c53d5781221e304e56
parent188cd4f440ed6bb2b3120ade9a2277c91d79215c
Fix ALTER DEFAULT PRIVILEGES with duplicated objects

Specifying duplicated objects in this command would lead to unique
constraint violations in pg_default_acl or "tuple already updated by
self" errors.  Similarly to GRANT/REVOKE, increment the command ID after
each subcommand processing to allow this case to work transparently.

A regression test is added by tweaking one of the existing queries of
privileges.sql to stress this case.

Reported-by: Andrus
Author: Michael Paquier
Reviewed-by: Álvaro Herrera
Discussion: https://postgr.es/m/ae2a7dc1-9d71-8cba-3bb9-e4cb7eb1f44e@hot.ee
Backpatch-through: 9.5
src/backend/catalog/aclchk.c
src/test/regress/expected/privileges.out
src/test/regress/sql/privileges.sql