Fix fractional vacuum_cost_delay.
authorThomas Munro <tmunro@postgresql.org>
Wed, 15 Mar 2023 00:57:00 +0000 (13:57 +1300)
committerThomas Munro <tmunro@postgresql.org>
Wed, 15 Mar 2023 01:05:27 +0000 (14:05 +1300)
commit2bef57ee8b38ee7fdbad3fb38b1f8ed31adb381b
tree417d508a21c750f308fe0cfa33bc50b927a0034a
parent9b6e0b9c37d644bc99f7c79e01b388f6a3648387
Fix fractional vacuum_cost_delay.

Commit 4753ef37 changed vacuum_delay_point() to use the WaitLatch() API,
to fix the problem that vacuum could keep running for a very long time
after the postmaster died.

Unfortunately, that broke commit caf626b2's support for fractional
vacuum_cost_delay, which shipped in PostgreSQL 12.  WaitLatch() works in
whole milliseconds.

For now, revert the change from commit 4753ef37, but add an explicit
check for postmaster death.  That's an extra system call on systems
other than Linux and FreeBSD, but that overhead doesn't matter much
considering that we willingly went to sleep and woke up again.  (In
later work, we might add higher resolution timeouts to the latch API so
that we could do this with our standard programming pattern, but that
wouldn't be back-patched.)

Back-patch to 14, where commit 4753ef37 arrived.

Reported-by: Melanie Plageman <melanieplageman@gmail.com>
Discussion: https://postgr.es/m/CAAKRu_b-q0hXCBUCAATh0Z4Zi6UkiC0k2DFgoD3nC-r3SkR3tg%40mail.gmail.com
src/backend/commands/vacuum.c