Fix toast rewrites in logical decoding.
authorAmit Kapila <akapila@postgresql.org>
Wed, 25 Aug 2021 04:23:07 +0000 (09:53 +0530)
committerAmit Kapila <akapila@postgresql.org>
Wed, 25 Aug 2021 04:23:07 +0000 (09:53 +0530)
commit29b5905470285bf730f6fe7cc5ddb3513d0e6945
tree7b3bd425435aad41025a846c9d74f4c28dbc0d70
parent255ed90fd260061b4261569151539068be262b51
Fix toast rewrites in logical decoding.

Commit 325f2ec555 introduced pg_class.relwrite to skip operations on
tables created as part of a heap rewrite during DDL. It links such
transient heaps to the original relation OID via this new field in
pg_class but forgot to do anything about toast tables. So, logical
decoding was not able to skip operations on internally created toast
tables. This leads to an error when we tried to decode the WAL for the
next operation for which it appeared that there is a toast data where
actually it didn't have any toast data.

To fix this, we set pg_class.relwrite for internally created toast tables
as well which allowed skipping operations on them during logical decoding.

Author: Bertrand Drouvot
Reviewed-by: David Zhang, Amit Kapila
Backpatch-through: 11, where it was introduced
Discussion: https://postgr.es/m/b5146fb1-ad9e-7d6e-f980-98ed68744a7c@amazon.com
contrib/test_decoding/expected/toast.out
contrib/test_decoding/sql/toast.sql
src/backend/catalog/toasting.c
src/backend/commands/cluster.c
src/backend/commands/tablecmds.c
src/include/catalog/toasting.h
src/include/commands/tablecmds.h