Don't allow to set replication slot_name as ''.
authorAmit Kapila <akapila@postgresql.org>
Mon, 19 Jul 2021 05:06:15 +0000 (10:36 +0530)
committerAmit Kapila <akapila@postgresql.org>
Mon, 19 Jul 2021 05:06:15 +0000 (10:36 +0530)
commit29abde637bbb4b8fcdc96e049813890afa5ab671
tree9b90b99b8a836d407f047ea205591602fa27b278
parent04cad8f7bcd63fac567e49fd72e6df42b3b251a9
Don't allow to set replication slot_name as ''.

We don't allow to create replication slot_name as an empty string ('') via
SQL API pg_create_logical_replication_slot() but it is allowed to be set
via Alter Subscription command. This will lead to apply worker repeatedly
keep trying to stream data via slot_name '' and the user is not allowed to
create the slot with that name.

Author: Japin Li
Reviewed-By: Ranier Vilela, Amit Kapila
Backpatch-through: 10, where it was introduced
Discussion: https://postgr.es/m/MEYP282MB1669CBD98E721C77CA696499B61A9@MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
src/backend/commands/subscriptioncmds.c
src/test/regress/expected/subscription.out
src/test/regress/sql/subscription.sql