libpq: Use strerror_r instead of strerror
authorPeter Eisentraut <peter@eisentraut.org>
Sun, 28 Jul 2024 07:12:00 +0000 (09:12 +0200)
committerPeter Eisentraut <peter@eisentraut.org>
Sun, 28 Jul 2024 07:23:24 +0000 (09:23 +0200)
commit1e666fd7c6d3bff658cdbad02b4e7bb77dde391d
tree0c3076dd40b0b4b58824a31e0eb00344a04077f6
parentda4017a694de0610bd5b3a54adda311e46e26300
libpq: Use strerror_r instead of strerror

Commit 453c4687377 introduced a use of strerror() into libpq, but that
is not thread-safe.  Fix by using strerror_r() instead.

In passing, update some of the code comments added by 453c4687377, as
we have learned more about the reason for the change in OpenSSL that
started this.

Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: Discussion: https://postgr.es/m/b6fb018b-f05c-4afd-abd3-318c649faf18@highgo.ca
src/backend/libpq/be-secure-openssl.c
src/interfaces/libpq/fe-secure-openssl.c